Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(material/sidenav): fix sidenav not working #30390

Closed
wants to merge 1 commit into from

Conversation

naaajii
Copy link
Contributor

@naaajii naaajii commented Jan 25, 2025

fixes broken example for responsive sidebar which included routerLink directive but is missing router module which prevents sidebar from opening by removing directive as it serve no purpose

fixes #30307

image

fixes broken example for responsive sidebar which included routerLink directive but is missing router module which prevents sidebar from opening by removing directive as it serve no purpose

fixes angular#30307
@naaajii naaajii requested a review from a team as a code owner January 25, 2025 18:52
@naaajii naaajii requested review from crisbeto and wagnermaciel and removed request for a team January 25, 2025 18:52
@angular-robot angular-robot bot added area: docs Related to the documentation area: material/sidenav labels Jan 25, 2025
@wagnermaciel wagnermaciel added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 27, 2025
@wagnermaciel wagnermaciel removed the request for review from crisbeto January 27, 2025 13:48
@wagnermaciel wagnermaciel added target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release labels Jan 27, 2025
@wagnermaciel
Copy link
Contributor

Something went wrong while merging this PR, but the change has landed in main. I'm going to open another PR and cherry pick that commit so it can also land in patch

wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 27, 2025
fixes broken example for responsive sidebar which included routerLink directive but is missing router module which prevents sidebar from opening by removing directive as it serve no purpose

fixes angular#30307
wagnermaciel added a commit that referenced this pull request Jan 27, 2025
fixes broken example for responsive sidebar which included routerLink directive but is missing router module which prevents sidebar from opening by removing directive as it serve no purpose

fixes #30307

Co-authored-by: Naji <54370141+naaajii@users.noreply.github.com>
angular-robot pushed a commit to angular-robot/components that referenced this pull request Jan 27, 2025
fixes broken example for responsive sidebar which included routerLink directive but is missing router module which prevents sidebar from opening by removing directive as it serve no purpose

fixes angular#30307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: material/sidenav target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs-bug(Sidenav): stackblitz example not loading
2 participants