fix(material/select): overlay not detached on time after exit animation in some cases #30456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
mmalerba and
wagnermaciel
and removed request for
a team
crisbeto
commented
Feb 7, 2025
| this._overlayDir.detachOverlay(); | ||
| // Some of the overlay detachment logic depends on change detection. | ||
| // Mark for check to ensure that things get picked up in a timely manner. | ||
| this._changeDetectorRef.markForCheck(); |
There was a problem hiding this comment.
This is the main part of the fix. The rest is removing the runOutsideAngular call, because marking for check outside the zone used to be problematic, not sure if that's the case anymore but am playing it safe.
…on in some cases Fixes an issue that was reported internally where in some setups the select would animate away, but wouldn't be detached after the exit animation until the next change detection.
crisbeto
force-pushed
the
select-animation-glitch
branch
from
3d5df1d to
b3d04dc
Compare
andrewseguin
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue that was reported internally where in some setups the select would animate away, but wouldn't be detached after the exit animation until the next change detection.