fix(cdk/drag-drop): incorrect type DragConstrainPosition #30510
Merged
+16
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veribelll
requested review from
crisbeto and
wagnermaciel
and removed request for
a team
Veribelll
force-pushed
the
fix-cdk-drag-constrain-position-type
branch
from
d775412 to
7ca6ef5
Compare
Fixes type DragConstrainPosition, which of сorrect configuration of CdkDrag is not possible when using in providers Fixes angular#30509
Veribelll
force-pushed
the
fix-cdk-drag-constrain-position-type
branch
from
7ca6ef5 to
0abfecd
Compare
crisbeto
reviewed
Feb 18, 2025
…Position Impot the type from the configuration CdkDrag for input cdkDragConstrainPosition, which leads to type safety.
Impot the type from the configuration CdkRef for property constrainPosition, which leads to type safety.
fix circular dependency
|
Looks like the API goldens still need to be updated. |
DragConstrainPosition type should be in the documentation
|
Forgot to add DragConstrainPosition in public api. Done. |
crisbeto
approved these changes
Feb 21, 2025
crisbeto
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes type DragConstrainPosition, which of сorrect configuration of CdkDrag is not possible when using in providers
Fixes #30509