Skip to content

refactor(cdk-experimental/ui-patterns): loosen the API to accept different types of signals #30597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2025
Merged

refactor(cdk-experimental/ui-patterns): loosen the API to accept different types of signals #30597

merged 1 commit into from
Mar 6, 2025

Conversation

wagnermaciel
Copy link
Contributor

No description provided.

@wagnermaciel wagnermaciel requested a review from jelbourn March 6, 2025 15:44
@wagnermaciel wagnermaciel requested a review from a team as a code owner March 6, 2025 15:44
@wagnermaciel wagnermaciel requested review from crisbeto and removed request for a team March 6, 2025 15:44
@wagnermaciel wagnermaciel changed the title Ng aria signals refactor(cdk-experimental/ui-patterns): avoid using Angular signals except computed Mar 6, 2025
@wagnermaciel wagnermaciel added merge: preserve commits When the PR is merged, a rebase and merge should be performed target: patch This PR is targeted for the next patch release labels Mar 6, 2025
jelbourn
jelbourn approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel removed the merge: preserve commits When the PR is merged, a rebase and merge should be performed label Mar 6, 2025
@wagnermaciel
refactor(cdk-experimental/ui-patterns): loosen the API to accept diff…
92d28cd 
…erent types of signals

* Introduces the SignalLike and WritableSignalLike types to avoid direct uses of Signal and WritableSignal
@wagnermaciel wagnermaciel changed the title refactor(cdk-experimental/ui-patterns): avoid using Angular signals except computed refactor(cdk-experimental/ui-patterns): loosen the API to accept different types of signals Mar 6, 2025
@wagnermaciel wagnermaciel removed the request for review from crisbeto March 6, 2025 17:00
@wagnermaciel wagnermaciel added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Mar 6, 2025
@mmalerba mmalerba added target: major This PR is targeted for the next major release and removed target: minor This PR is targeted for the next minor release labels Mar 6, 2025
@wagnermaciel wagnermaciel merged commit fedb4d4 into angular:main Mar 6, 2025
24 of 26 checks passed
@jelbourn jelbourn mentioned this pull request Mar 7, 2025
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wagnermaciel @jelbourn @mmalerba