fix(material/form-field): preserve aria-describedby set externally across all form controls #30699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adolgachev
force-pushed
the
ff-described
branch
from
c8199a5 to
edfd8dc
Compare
adolgachev
changed the title
adolgachev
requested review from
crisbeto and
andrewseguin
and removed request for
a team
adolgachev
force-pushed
the
ff-described
branch
from
f72a569 to
3e47349
Compare
|
TESTED=TGP |
…ross all form controls fix(material/form-field): preserve aria-describedby set externally across all form controls add describedbyids and use to preserve existing ids add describedByIds to input add comment Move better sync logic to formfield add describedByIds to other controls update api goldens tweak comment add more tests
adolgachev
force-pushed
the
ff-described
branch
from
a257872 to
d25cde7
Compare
adolgachev
added
action: review
andrewseguin
approved these changes
Apr 15, 2025
adolgachev
added
action: merge
|
Caretaker Note: Merge with cl/741319445. |
andrewseguin
added
target: major
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand fix for Input to properly handle aria-describedby set manually (e.g. by AriaDescriber) to all form fields when syncing described by ids.