Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix jasmine types #3080

Merged
merged 1 commit into from
Feb 13, 2017
Merged

build: fix jasmine types #3080

merged 1 commit into from
Feb 13, 2017

Conversation

devversion
Copy link
Member

Currently gulp test shows some issues with the jasmine types.

These are now appearing because we didn't lock the dependency and with SHA DefinitelyTyped#4a80522 an TS issue has been introduced.

Just locking to the type version before fixes the issue.

Fixes #3074

@devversion devversion requested a review from kara February 13, 2017 19:01
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 13, 2017
kara
kara approved these changes Feb 13, 2017
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 13, 2017
@kara kara removed their assignment Feb 13, 2017
@andrewseguin andrewseguin merged commit 8eb9f88 into angular:master Feb 13, 2017
@devversion devversion deleted the build/fix-jasmine branch February 14, 2017 07:39
@trshafer trshafer mentioned this pull request Feb 16, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit tests process crashes
4 participants
@devversion @kara @googlebot @andrewseguin