fix(material/bottom-sheet): page jumping if backdrop-filter is applied #30840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bottom sheet has an animation where it starts off-screen and animates in. At the same time it moves focus into itself. It seems like under certain conditions (e.g. having `backdrop-filter` on the `body`) this causes the entire page the jump in a jarring way due to the focus being moved. These changes resolve the issue by telling the browser not to scroll the page when moving focus. Fixes angular#30774.
crisbeto
requested review from
mmalerba and
andrewseguin
and removed request for
a team
mmalerba
approved these changes
Apr 11, 2025
|
The changes were merged into the following branches: main, 19.2.x |
crisbeto
added a commit
that referenced
this pull request
Apr 11, 2025
#30840) The bottom sheet has an animation where it starts off-screen and animates in. At the same time it moves focus into itself. It seems like under certain conditions (e.g. having `backdrop-filter` on the `body`) this causes the entire page the jump in a jarring way due to the focus being moved. These changes resolve the issue by telling the browser not to scroll the page when moving focus. Fixes #30774. (cherry picked from commit 5dcbba7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bottom sheet has an animation where it starts off-screen and animates in. At the same time it moves focus into itself. It seems like under certain conditions (e.g. having
backdrop-filteron thebody) this causes the entire page the jump in a jarring way due to the focus being moved.These changes resolve the issue by telling the browser not to scroll the page when moving focus.
Fixes #30774.