feat(e2e): Take screenshots for grid-list, list, icon, menu, radio, tabs, slide-toggle #3098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tinayuangao
commented
Feb 15, 2017
tinayuangao
commented
- Updated button and checkbox e2e test so the screenshot wait for ripple animation to finish
- Added screenshots for grid-list, list, icon, menu, radio, tabs, slide-toggle
- Skipped some tests which UI is already tested. Also skipped e2e tests with animation.
googlebot
added
the
cla: yes
tinayuangao
force-pushed
the
screenshots-e2e
branch
from
6104026 to
25a168d
Compare
mmalerba
approved these changes
Feb 15, 2017
crisbeto
reviewed
Feb 15, 2017
|
|
||
| describe('grid-list', () => { | ||
| beforeEach(() => browser.get('/grid-list')); | ||
|
|
||
| it('should render a grid list container', () => { | ||
| expectToExist('md-grid-list'); | ||
| screenshot(''); |
There was a problem hiding this comment.
This could be improved by either having the id be an optional param, or making it default to ''.
|
Made Currently there's no way to see the screenshots. Once #2774 get in we can view the screenshots from https://material2-screenshots.firebaseapp.com/PR# |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.