fix(material/button-toggle): use smaller border radius #31084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the button toggle uses the `corner-full` value for its broder radius which starts too look weird for a vertical group with text inside the toggles. These changes switch to using the `corner-extra-large` value instead. Fixes angular#31010.
crisbeto
requested review from
mmalerba and
wagnermaciel
and removed request for
a team
andrewseguin
added
the
dev-app preview
|
Deployed dev-app for 13603e1 to: https://ng-dev-previews-comp--pr-angular-components-31084-dev-pkgqrxgp.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
andrewseguin
approved these changes
May 12, 2025
|
The changes were merged into the following branches: main, 19.2.x, 20.0.x |
wildcardalice
pushed a commit
to wildcardalice/components
that referenced
this pull request
May 12, 2025
Currently the button toggle uses the `corner-full` value for its broder radius which starts too look weird for a vertical group with text inside the toggles. These changes switch to using the `corner-extra-large` value instead. Fixes angular#31010.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the button toggle uses the
corner-fullvalue for its broder radius which starts too look weird for a vertical group with text inside the toggles.These changes switch to using the
corner-extra-largevalue instead.Fixes #31010.