fix(material/tabs): avoid not having any focusable tabs #31144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
adolgachev,
mmalerba and
andrewseguin
and removed request for
a team
andrewseguin
approved these changes
May 19, 2025
In angular#26397 we made it possible to navigate to disabled tabs with the keyboard, however in the tabs nav bar they're still set to `tabindex="-1"` unless they're active. This means that if the nav bar only has disabled tabs, there's no way to enter it. These changes make it so the tab index is based on the focus index which ensures that at least one tab is always focusable. It also aligns the behavior with `mat-tab-group`.
crisbeto
force-pushed
the
tab-link-tabindex
branch
from
1e826ff to
ef0e2d0
Compare
|
The changes were merged into the following branches: main, 19.2.x, 20.0.x |
crisbeto
added a commit
that referenced
this pull request
May 19, 2025
* fix(material/tabs): avoid not having any focusable tabs In #26397 we made it possible to navigate to disabled tabs with the keyboard, however in the tabs nav bar they're still set to `tabindex="-1"` unless they're active. This means that if the nav bar only has disabled tabs, there's no way to enter it. These changes make it so the tab index is based on the focus index which ensures that at least one tab is always focusable. It also aligns the behavior with `mat-tab-group`. * fixup! fix(material/tabs): avoid not having any focusable tabs (cherry picked from commit 98065ce)
crisbeto
added a commit
that referenced
this pull request
May 19, 2025
* fix(material/tabs): avoid not having any focusable tabs In #26397 we made it possible to navigate to disabled tabs with the keyboard, however in the tabs nav bar they're still set to `tabindex="-1"` unless they're active. This means that if the nav bar only has disabled tabs, there's no way to enter it. These changes make it so the tab index is based on the focus index which ensures that at least one tab is always focusable. It also aligns the behavior with `mat-tab-group`. * fixup! fix(material/tabs): avoid not having any focusable tabs (cherry picked from commit 98065ce)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #26397 we made it possible to navigate to disabled tabs with the keyboard, however in the tabs nav bar they're still set to
tabindex="-1"unless they're active. This means that if the nav bar only has disabled tabs, there's no way to enter it.These changes make it so the tab index is based on the focus index which ensures that at least one tab is always focusable. It also aligns the behavior with
mat-tab-group.