-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(cdk-experimental/radio): add radio demo to dev-app #31180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deployed dev-app for e159090 to: https://ng-dev-previews-comp--pr-angular-components-31180-dev-7ftid85f.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
70d176e
to
5a8e266
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that if an option is disabled and selected programmatically, you can still toggle other options with aria-checked
. It can just be a bad usage if done by developers, or should we
- Only have the disabled option checked, and other options always have
aria-checked="false"
. - Force the disabled option to be not selectable (always has
aria-checked="false"
).
src/components-examples/cdk-experimental/radio/cdk-radio/cdk-radio-example.html
Outdated
Show resolved
Hide resolved
I think option 1 makes the most sense. I'm wondering if the radio group should automatically set |
Making the group Tested by setting readonly, skip disabled, selected a flavor that is also disabled. Navigating through the radio buttons and it skips the only one that is announced as "selected". However this can just be a really bad setup that the developers should aware of that. |
Yeah, that's true. I think setting readonly would be the best way to move forward and I can add some basic validation to warn developers about this particular edge case. |
7bf4c9a
to
0203e25
Compare
0203e25
to
fd0dd59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validation!
No description provided.