fix(ripple): different durations for ripple elements #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* No longer uses a `PX_PER_SECOND` variable to calculate the fade-in duration of a ripple element. * Now ripple elements always have the same `transitionDuration`, which ensures that ripples are faster on bigger elements and slower on smaller elements. Fixes angular#3109
googlebot
added
the
cla: yes
andrewseguin
added
pr: lgtm
action: merge
devversion
added a commit
to devversion/material2
that referenced
this pull request
Feb 17, 2017
* Since PR angular#3136 changed the default duration for ripple elements, the slide-toggle ripples are now way too slow.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Feb 17, 2017
* Since PR angular#3136 changed the default duration for ripple elements, the slide-toggle ripples are now way too slow.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Feb 25, 2017
* Since PR angular#3136 changed the default duration for ripple elements, the slide-toggle ripples are now way too slow.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PX_PER_SECONDvariable to calculate the fade-in duration of a ripple element.transitionDuration, which ensures that ripples are faster on bigger elements and slower on smaller elements.Fixes #3109