Skip to content

test(multiple): clean up some unnecessary imports #31605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/cdk-experimental/accordion/accordion.spec.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import {Component, DebugElement, signal, model} from '@angular/core';
import {ComponentFixture, TestBed} from '@angular/core/testing';
import {By} from '@angular/platform-browser';
import {BidiModule} from '@angular/cdk/bidi';
import {provideFakeDirectionality, runAccessibilityChecks} from '@angular/cdk/testing/private';
import {_IdGenerator} from '@angular/cdk/a11y';
import {
Expand Down Expand Up @@ -97,7 +96,6 @@ describe('CdkAccordionGroup', () => {
beforeEach(() => {
TestBed.configureTestingModule({
providers: [provideFakeDirectionality('ltr'), _IdGenerator],
imports: [BidiModule, AccordionGroupExample],
});

fixture = TestBed.createComponent(AccordionGroupExample);
Expand Down
18 changes: 2 additions & 16 deletions src/cdk-experimental/combobox/combobox.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,6 @@ describe('Combobox', () => {
let applyButton: DebugElement;
let applyButtonElement: HTMLElement;

beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [CdkComboboxModule, ComboboxToggle],
});
}));

beforeEach(() => {
fixture = TestBed.createComponent(ComboboxToggle);
fixture.detectChanges();
Expand Down Expand Up @@ -189,11 +183,7 @@ describe('Combobox', () => {
let combobox: DebugElement;
let comboboxInstance: CdkCombobox;

beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [CdkComboboxModule, ComboboxToggle],
});
}));
beforeEach(waitForAsync(() => {}));

beforeEach(() => {
fixture = TestBed.createComponent(ComboboxToggle);
Expand Down Expand Up @@ -259,11 +249,7 @@ describe('Combobox', () => {
let comboboxInstance: CdkCombobox;
let comboboxElement: HTMLElement;

beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [CdkComboboxModule, ComboboxToggle],
});
}));
beforeEach(waitForAsync(() => {}));

beforeEach(() => {
fixture = TestBed.createComponent(ComboboxToggle);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,18 +1,12 @@
import {Component, DebugElement, Directive, effect, inject, signal} from '@angular/core';
import {ComponentFixture, TestBed, waitForAsync} from '@angular/core/testing';
import {ComponentFixture, TestBed} from '@angular/core/testing';
import {DeferredContent, DeferredContentAware} from './deferred-content';
import {By} from '@angular/platform-browser';

describe('DeferredContent', () => {
let fixture: ComponentFixture<TestComponent>;
let collapsible: DebugElement;

beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [TestComponent],
});
}));

beforeEach(() => {
fixture = TestBed.createComponent(TestComponent);
collapsible = fixture.debugElement.query(By.directive(Collapsible));
Expand Down
4 changes: 1 addition & 3 deletions src/cdk-experimental/listbox/listbox.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {Component, DebugElement, signal} from '@angular/core';
import {CdkListbox, CdkOption} from './listbox';
import {ComponentFixture, TestBed, fakeAsync, tick} from '@angular/core/testing';
import {By} from '@angular/platform-browser';
import {BidiModule, Direction} from '@angular/cdk/bidi';
import {Direction} from '@angular/cdk/bidi';
import {provideFakeDirectionality, runAccessibilityChecks} from '@angular/cdk/testing/private';

interface ModifierKeys {
Expand Down Expand Up @@ -65,7 +65,6 @@ describe('CdkListbox', () => {
}) {
TestBed.configureTestingModule({
providers: [provideFakeDirectionality(opts?.textDirection ?? 'ltr')],
imports: [BidiModule, ListboxExample],
});

fixture = TestBed.createComponent(ListboxExample);
Expand Down Expand Up @@ -98,7 +97,6 @@ describe('CdkListbox', () => {
function setupDefaultListbox() {
TestBed.configureTestingModule({
providers: [provideFakeDirectionality('ltr')],
imports: [BidiModule, DefaultListboxExample],
});

const defaultFixture = TestBed.createComponent(DefaultListboxExample);
Expand Down
4 changes: 1 addition & 3 deletions src/cdk-experimental/radio-group/radio-group.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {Component, DebugElement, signal} from '@angular/core';
import {CdkRadioButton, CdkRadioGroup} from './radio-group';
import {ComponentFixture, TestBed} from '@angular/core/testing';
import {By} from '@angular/platform-browser';
import {BidiModule, Direction} from '@angular/cdk/bidi';
import {Direction} from '@angular/cdk/bidi';
import {provideFakeDirectionality, runAccessibilityChecks} from '@angular/cdk/testing/private';

describe('CdkRadioGroup', () => {
Expand Down Expand Up @@ -45,7 +45,6 @@ describe('CdkRadioGroup', () => {
}) {
TestBed.configureTestingModule({
providers: [provideFakeDirectionality(opts?.textDirection ?? 'ltr')],
imports: [BidiModule, RadioGroupExample],
});

fixture = TestBed.createComponent(RadioGroupExample);
Expand Down Expand Up @@ -85,7 +84,6 @@ describe('CdkRadioGroup', () => {
function setupDefaultRadioGroup() {
TestBed.configureTestingModule({
providers: [provideFakeDirectionality('ltr')],
imports: [BidiModule, DefaultRadioGroupExample],
});

const fixture = TestBed.createComponent(DefaultRadioGroupExample);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {CdkVirtualScrollViewport, ScrollingModule} from '@angular/cdk/scrolling';
import {Component, Input, ViewChild, ViewEncapsulation} from '@angular/core';
import {ComponentFixture, TestBed, fakeAsync, flush, waitForAsync} from '@angular/core/testing';
import {ComponentFixture, TestBed, fakeAsync, flush} from '@angular/core/testing';
import {ScrollingModule as ExperimentalScrollingModule} from './scrolling-module';

describe('CdkVirtualScrollViewport', () => {
Expand All @@ -9,12 +9,6 @@ describe('CdkVirtualScrollViewport', () => {
let testComponent: AutoSizeVirtualScroll;
let viewport: CdkVirtualScrollViewport;

beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [ScrollingModule, ExperimentalScrollingModule, AutoSizeVirtualScroll],
});
}));

beforeEach(() => {
fixture = TestBed.createComponent(AutoSizeVirtualScroll);
testComponent = fixture.componentInstance;
Expand Down
26 changes: 1 addition & 25 deletions src/cdk-experimental/selection/selection.spec.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {AsyncPipe} from '@angular/common';
import {CdkTableModule} from '@angular/cdk/table';
import {ChangeDetectorRef, Component, ElementRef, ViewChild, inject} from '@angular/core';
import {waitForAsync, ComponentFixture, fakeAsync, flush, TestBed} from '@angular/core/testing';
import {ComponentFixture, fakeAsync, flush, TestBed} from '@angular/core/testing';

import {CdkSelection} from './selection';
import {CdkSelectionModule} from './selection-module';
Expand All @@ -11,12 +11,6 @@ describe('CdkSelection', () => {
let fixture: ComponentFixture<ListWithMultiSelection>;
let component: ListWithMultiSelection;

beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [CdkSelectionModule, ListWithMultiSelection],
});
}));

beforeEach(() => {
fixture = TestBed.createComponent(ListWithMultiSelection);
component = fixture.componentInstance;
Expand Down Expand Up @@ -237,12 +231,6 @@ describe('CdkSelection with multiple = false', () => {
let fixture: ComponentFixture<ListWithSingleSelection>;
let component: ListWithSingleSelection;

beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [CdkSelectionModule, ListWithSingleSelection],
});
}));

beforeEach(() => {
fixture = TestBed.createComponent(ListWithSingleSelection);
component = fixture.componentInstance;
Expand Down Expand Up @@ -302,12 +290,6 @@ describe('cdkSelectionColumn', () => {
let fixture: ComponentFixture<MultiSelectTableWithSelectionColumn>;
let component: MultiSelectTableWithSelectionColumn;

beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [CdkSelectionModule, CdkTableModule, MultiSelectTableWithSelectionColumn],
});
}));

beforeEach(fakeAsync(() => {
fixture = TestBed.createComponent(MultiSelectTableWithSelectionColumn);
component = fixture.componentInstance;
Expand Down Expand Up @@ -397,12 +379,6 @@ describe('cdkSelectionColumn with multiple = false', () => {
let fixture: ComponentFixture<SingleSelectTableWithSelectionColumn>;
let component: SingleSelectTableWithSelectionColumn;

beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [CdkSelectionModule, CdkTableModule, SingleSelectTableWithSelectionColumn],
});
}));

beforeEach(() => {
fixture = TestBed.createComponent(SingleSelectTableWithSelectionColumn);
component = fixture.componentInstance;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,19 +18,12 @@ describe('CdkTableScrollContainer', () => {
let headerRows: HTMLElement[];
let footerRows: HTMLElement[];

function createComponent<T>(
componentType: Type<T>,
declarations: any[] = [],
): ComponentFixture<T> {
TestBed.configureTestingModule({
imports: [CdkTableModule, CdkTableScrollContainerModule, componentType, ...declarations],
});

function createComponent<T>(componentType: Type<T>): ComponentFixture<T> {
return TestBed.createComponent<T>(componentType);
}

function setupTableTestApp(componentType: Type<any>, declarations: any[] = []) {
fixture = createComponent(componentType, declarations);
function setupTableTestApp(componentType: Type<any>) {
fixture = createComponent(componentType);
component = fixture.componentInstance;
fixture.detectChanges();

Expand Down
3 changes: 1 addition & 2 deletions src/cdk-experimental/tabs/tabs.spec.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {Component, DebugElement, signal} from '@angular/core';
import {ComponentFixture, TestBed} from '@angular/core/testing';
import {By} from '@angular/platform-browser';
import {BidiModule, Direction} from '@angular/cdk/bidi';
import {Direction} from '@angular/cdk/bidi';
import {provideFakeDirectionality, runAccessibilityChecks} from '@angular/cdk/testing/private';
import {CdkTabs, CdkTabList, CdkTab, CdkTabPanel, CdkTabContent} from './tabs';

Expand Down Expand Up @@ -63,7 +63,6 @@ describe('CdkTabs', () => {
function setupTestTabs(options: {textDirection?: Direction} = {}) {
TestBed.configureTestingModule({
providers: [provideFakeDirectionality(options.textDirection ?? 'ltr')],
imports: [BidiModule, TestTabsComponent],
});

fixture = TestBed.createComponent(TestTabsComponent);
Expand Down
3 changes: 1 addition & 2 deletions src/cdk-experimental/tree/tree.spec.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {Component, signal} from '@angular/core';
import {ComponentFixture, TestBed} from '@angular/core/testing';
import {By} from '@angular/platform-browser';
import {BidiModule, Direction} from '@angular/cdk/bidi';
import {Direction} from '@angular/cdk/bidi';
import {provideFakeDirectionality, runAccessibilityChecks} from '@angular/cdk/testing/private';
import {CdkTree, CdkTreeItem, CdkTreeItemGroup, CdkTreeItemGroupContent} from './tree';

Expand Down Expand Up @@ -53,7 +53,6 @@ describe('CdkTree', () => {

function setupTestTree(textDirection: Direction = 'ltr') {
TestBed.configureTestingModule({
imports: [TestTreeComponent, BidiModule],
providers: [provideFakeDirectionality(textDirection)],
});

Expand Down
1 change: 0 additions & 1 deletion src/cdk/a11y/aria-describer/aria-describer.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ describe('AriaDescriber', () => {

function createFixture(providers: Provider[] = []) {
TestBed.configureTestingModule({
imports: [A11yModule, TestApp],
providers: [AriaDescriber, ...providers],
});

Expand Down
20 changes: 0 additions & 20 deletions src/cdk/a11y/focus-monitor/focus-monitor.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ describe('FocusMonitor', () => {
fakeActiveElement = null;

TestBed.configureTestingModule({
imports: [A11yModule, PlainButton],
providers: [
{
provide: DOCUMENT,
Expand Down Expand Up @@ -466,7 +465,6 @@ describe('FocusMonitor with "eventual" detection', () => {

beforeEach(() => {
TestBed.configureTestingModule({
imports: [A11yModule, PlainButton],
providers: [
{
provide: FOCUS_MONITOR_DEFAULT_OPTIONS,
Expand Down Expand Up @@ -499,20 +497,6 @@ describe('FocusMonitor with "eventual" detection', () => {
});

describe('cdkMonitorFocus', () => {
beforeEach(() => {
TestBed.configureTestingModule({
imports: [
A11yModule,
ButtonWithFocusClasses,
ComplexComponentWithMonitorElementFocus,
ComplexComponentWithMonitorSubtreeFocus,
ComplexComponentWithMonitorSubtreeFocusAndMonitorElementFocus,
FocusMonitorOnCommentNode,
ExportedFocusMonitor,
],
});
});

describe('button with cdkMonitorElementFocus', () => {
let fixture: ComponentFixture<ButtonWithFocusClasses>;
let buttonElement: HTMLElement;
Expand Down Expand Up @@ -820,7 +804,6 @@ describe('FocusMonitor observable stream', () => {
beforeEach(() => {
fakePlatform = {isBrowser: true} as Platform;
TestBed.configureTestingModule({
imports: [A11yModule, PlainButton],
providers: [{provide: Platform, useValue: fakePlatform}],
});
fixture = TestBed.createComponent(PlainButton);
Expand Down Expand Up @@ -854,9 +837,6 @@ describe('FocusMonitor input label detection', () => {
let focusMonitor: FocusMonitor;

beforeEach(() => {
TestBed.configureTestingModule({
imports: [A11yModule, CheckboxWithLabel],
});
fixture = TestBed.createComponent(CheckboxWithLabel);
focusMonitor = TestBed.inject(FocusMonitor);
fixture.detectChanges();
Expand Down
1 change: 0 additions & 1 deletion src/cdk/a11y/focus-monitor/focus-monitor.zone.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ describe('FocusMonitor observable stream Zone.js integration', () => {
beforeEach(() => {
fakePlatform = {isBrowser: true} as Platform;
TestBed.configureTestingModule({
imports: [A11yModule, PlainButton],
providers: [{provide: Platform, useValue: fakePlatform}, provideZoneChangeDetection()],
});
fixture = TestBed.createComponent(PlainButton);
Expand Down
2 changes: 0 additions & 2 deletions src/cdk/a11y/focus-trap/configurable-focus-trap.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import {
} from '@angular/core';
import {ComponentFixture, TestBed} from '@angular/core/testing';
import {
A11yModule,
ConfigurableFocusTrap,
ConfigurableFocusTrapFactory,
FOCUS_TRAP_INERT_STRATEGY,
Expand Down Expand Up @@ -101,7 +100,6 @@ function createComponent<T>(
providers: Provider[] = [],
): ComponentFixture<T> {
TestBed.configureTestingModule({
imports: [A11yModule, componentType],
providers: providers,
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import {
import {ComponentFixture, TestBed, fakeAsync, flush} from '@angular/core/testing';
import {patchElementFocus} from '../../testing/private';
import {
A11yModule,
ConfigurableFocusTrap,
ConfigurableFocusTrapFactory,
EventListenerFocusTrapInertStrategy,
Expand Down Expand Up @@ -69,10 +68,7 @@ function createComponent<T>(
componentType: Type<T>,
providers: Provider[] = [],
): ComponentFixture<T> {
TestBed.configureTestingModule({
imports: [A11yModule, componentType],
providers: providers,
});
TestBed.configureTestingModule({providers});

return TestBed.createComponent<T>(componentType);
}
Expand Down
18 changes: 0 additions & 18 deletions src/cdk/a11y/focus-trap/focus-trap.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,24 +13,6 @@ import {By} from '@angular/platform-browser';
import {A11yModule, CdkTrapFocus, FocusTrap} from '../index';

describe('FocusTrap', () => {
beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [
A11yModule,
PortalModule,
FocusTrapWithBindings,
SimpleFocusTrap,
FocusTrapTargets,
FocusTrapWithSvg,
FocusTrapWithoutFocusableElements,
FocusTrapWithAutoCapture,
FocusTrapUnfocusableTarget,
FocusTrapInsidePortal,
FocusTrapWithAutoCaptureInShadowDom,
],
});
}));

describe('with default element', () => {
let fixture: ComponentFixture<SimpleFocusTrap>;
let focusTrapInstance: FocusTrap;
Expand Down
Loading
Loading