-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(input): add directive for displaying error messages #3560
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
42dab5e
feat(input): add directive for displayed error messages
crisbeto c7e2d69
chore: lint and aot errors
crisbeto a9d144a
fix: address feedback
crisbeto 6706708
fix: address more feedback
crisbeto dcd029a
chore: use FormGroup properly
crisbeto 3a82990
refactor: switch back to showing hints when valid
crisbeto 3744a13
errror
crisbeto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,6 +51,51 @@ | |
</md-card-content> | ||
</md-card> | ||
|
||
<md-card class="demo-card demo-basic"> | ||
<md-toolbar color="primary">Error messages</md-toolbar> | ||
<md-card-content> | ||
<h4>Regular</h4> | ||
|
||
<p> | ||
<md-input-container> | ||
<input mdInput placeholder="example" [(ngModel)]="errorMessageExample1" required> | ||
<md-error>This field is required</md-error> | ||
</md-input-container> | ||
|
||
<md-input-container> | ||
<input mdInput placeholder="email" [formControl]="emailFormControl"> | ||
<md-error *ngIf="emailFormControl.hasError('required')"> | ||
This field is required | ||
</md-error> | ||
<md-error *ngIf="emailFormControl.hasError('pattern')"> | ||
Please enter a valid email address | ||
</md-error> | ||
</md-input-container> | ||
</p> | ||
|
||
<h4>With hint</h4> | ||
|
||
<md-input-container> | ||
<input mdInput placeholder="example" [(ngModel)]="errorMessageExample2" required> | ||
<md-error>This field is required</md-error> | ||
<md-hint>Please type something here</md-hint> | ||
</md-input-container> | ||
|
||
|
||
<form novalidate> | ||
<h4>Inside a form</h4> | ||
|
||
<md-input-container> | ||
<input mdInput name="example" placeholder="example" | ||
[(ngModel)]="errorMessageExample3" required> | ||
<md-error>This field is required</md-error> | ||
</md-input-container> | ||
|
||
<button color="primary" md-raised-button>Submit</button> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this button supposed to do something? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, it's used to test out that form submission shows the error messages. |
||
</form> | ||
</md-card-content> | ||
</md-card> | ||
|
||
<md-card class="demo-card demo-basic"> | ||
<md-toolbar color="primary">Prefix + Suffix</md-toolbar> | ||
<md-card-content> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the error animation is kind of strange in this case, the error message seems to appear in the middle of the input and then move down (I think because the message wraps on to 2 lines).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take another look. It probably needs a
transform-origin
.