Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(icon): add README.md #372

Merged
merged 2 commits into from
Apr 29, 2016
Merged

docs(icon): add README.md #372

merged 2 commits into from
Apr 29, 2016

Conversation

dozingcat
Copy link
Contributor

No description provided.

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement labels Apr 28, 2016
@dozingcat dozingcat mentioned this pull request Apr 28, 2016
@kara
Copy link
Contributor

kara commented Apr 28, 2016

Can you change your commit name to "docs(icon)"? :D

@dozingcat dozingcat changed the title chore(icon): add README.md docs(icon): add README.md Apr 28, 2016

By default the [Material icons font](http://google.github.io/material-design-icons/#icon-font-for-the-web) is used. (You will still need to include the HTML to load the font and its CSS, as described in the link). You can specify a different font by setting the `fontSet` input to either the CSS class to apply to use the desired font, or to an alias previously registered with `MdIconRegistry.registerFontClassAlias`, for example:
```javascript
mdIconRegistry.registerFontClassAlias('myfont', 'my-icon-font-class');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use FontAwesome in the example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FontAwesome doesn't use ligatures as far as I can tell so it might be confusing. Changed the CSS font icon example below.

@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn merged commit 9857f0f into angular:master Apr 29, 2016
@dozingcat dozingcat deleted the mdicon_readme branch April 29, 2016 18:02
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants