feat(snackbar): allow snack bar to be positioned on the page #4045

josephperrott · 2017-04-12T01:53:47Z

For #3577

jelbourn

As we discussed, I think I would want to make this more general before adding more positions

xtianus79 · 2017-04-27T14:56:59Z

@jelbourn and @josephperrott so this is going to be only left of center at first?

josephperrott · 2017-05-10T23:59:31Z

@jelbourn ready for you to take a look

jelbourn · 2017-05-11T18:19:53Z

src/lib/snack-bar/snack-bar-config.ts

@@ -1,6 +1,11 @@
 import {ViewContainerRef} from '@angular/core';
 import {AriaLivePoliteness} from '../core';

+export interface MdSnackBarPosition {
+  horizontal: string;
+  vertical: string;


The types for these should be a string literal enumeration

jelbourn · 2017-05-11T18:24:58Z

src/lib/snack-bar/snack-bar-config.ts

@@ -19,4 +24,10 @@ export class MdSnackBarConfig {

  /** Extra CSS classes to be added to the snack bar container. */
  extraClasses?: string[];
+
+  /** The position to place the snack bar in the view, either 'left' or 'center'.  */
+  position?: MdSnackBarPosition = {


I kind of want this to be two separate properties (verticalPosition and horizontalPosition)- it gives you the freedom to set just one if you want (easier defaults). Do you have a reason for making it a separate object?

jelbourn · 2017-05-11T18:25:35Z

src/lib/snack-bar/snack-bar-container.scss

  max-width: $mat-snack-bar-max-width;
  min-width: $mat-snack-bar-min-width;
  padding: $mat-snack-bar-padding;
  // Initial transformation is applied to start snack bar out of view.
  transform: translateY(100%);

+  &.md-snack-bar-center {


Add description comments for when these classes are applied / what they're used for

jelbourn · 2017-05-11T18:28:21Z

src/lib/snack-bar/snack-bar.ts

-        .bottom('0');
+    let positionStrategy = this._overlay.position().global();
+    switch (config.position.horizontal) {
+      case 'left':


Should be start and end instead of left and right, taking the RTL/LTR state into account

jelbourn · 2017-05-11T18:33:31Z

src/lib/snack-bar/snack-bar.ts

+      case 'bottom':
+        positionStrategy.bottom('0');
+        break;
+    }


Need unit test for using the appropriate position based on the config and ltr/rtl state

jelbourn · 2017-05-11T18:34:59Z

src/lib/snack-bar/snack-bar-container.ts

+
+    if (this.snackBarConfig.position.vertical === 'top') {
+      this._renderer.setElementClass(this._elementRef.nativeElement, 'md-snack-bar-top', true);
+    }


Need unit tests for setting these css classes when appropriate

soorireddy

Thank you for the changes , can we get this merged ASAP

xtianus79 · 2017-05-17T14:46:15Z

@jelbourn & @josephperrott would this just be in the next build or will be available on master branch anytime in the future

mmalerba · 2017-07-07T21:05:35Z

please rebase

xtianus79 · 2017-07-25T11:33:30Z

Is this going to make it into the next build? I'm really waiting for this feature. @josephperrott

koumatsumoto · 2017-08-18T08:31:29Z

I hope next build come with this changes.

xtianus79 · 2017-08-18T14:29:51Z

This release is taking longer than expected. Any idea when the next release is?

josephperrott · 2017-08-28T20:50:29Z

@jelbourn rebased and ready to be looked at.

jelbourn · 2017-09-01T15:10:31Z

@josephperrott can you rebase again?

josephperrott · 2017-09-01T16:45:40Z

@jelbourn Rebased and ready to go.

b4z81 · 2017-09-11T16:50:57Z

+1 merge please

xtianus79 · 2017-09-26T18:44:54Z

@jelbourn && @josephperrott did this end up making it into the latest build? If not, is there a new holdup for this feature?

jelbourn · 2017-09-26T19:01:44Z

This should be in beta.11

xtianus79 · 2017-09-26T19:08:06Z

@jelbourn yea!!! I looked in the release notes and didn't see it.

ORESoftware · 2018-02-17T23:52:10Z

How can we change the position/location of snackbar?

CDDelta · 2018-02-18T00:32:11Z

@ORESoftware have a look at this https://angular-vv8kca.stackblitz.io.

ORESoftware · 2018-02-18T00:53:30Z

ah yes thanks

angular-automatic-lock-bot · 2019-09-08T09:01:04Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 12, 2017

josephperrott force-pushed the snackbar branch from fe2e64f to f4d5bd1 Compare April 12, 2017 01:57

jelbourn self-assigned this Apr 12, 2017

jelbourn self-requested a review April 12, 2017 23:44

jelbourn added the pr: needs review label Apr 12, 2017

jelbourn reviewed Apr 14, 2017

View reviewed changes

jelbourn added in progress This issue is currently in progress and removed pr: needs review labels Apr 14, 2017

josephperrott force-pushed the snackbar branch 5 times, most recently from 8932bc7 to 6be0d6d Compare April 26, 2017 05:38

josephperrott force-pushed the snackbar branch 3 times, most recently from b1a462c to d9f16e9 Compare April 27, 2017 23:33

josephperrott changed the title ~~Allow snack bar position to be set to left or center.~~ feat(snackbar): allow snack bar to be positioned on the page Apr 28, 2017

josephperrott added the pr: needs review label Apr 28, 2017

merobal mentioned this pull request May 10, 2017

MdSnackBar: alignment & position #3577

Closed

josephperrott removed the in progress This issue is currently in progress label May 11, 2017

jelbourn reviewed May 11, 2017

View reviewed changes

josephperrott force-pushed the snackbar branch 4 times, most recently from 08f89e3 to a747c07 Compare May 13, 2017 00:17

soorireddy reviewed May 17, 2017

View reviewed changes

josephperrott force-pushed the snackbar branch from a747c07 to ee18409 Compare May 18, 2017 02:01

mmalerba added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Jul 7, 2017

josephperrott force-pushed the snackbar branch from 2f9d448 to 368b4a9 Compare August 28, 2017 17:06

josephperrott requested a review from crisbeto as a code owner August 28, 2017 17:06

josephperrott force-pushed the snackbar branch 2 times, most recently from 35f70d5 to 05c0854 Compare August 28, 2017 20:01

josephperrott removed the pr: needs rebase label Aug 28, 2017

jelbourn added action: merge The PR is ready for merge by the caretaker and removed presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged labels Aug 28, 2017

jelbourn mentioned this pull request Aug 30, 2017

Is there a reason that snackbar posititioning keeps getting put off? Can we please have this feature it is important to our build #6733

Closed

Allow snackbar position on the screen.

5f96375

josephperrott force-pushed the snackbar branch from 05c0854 to 5f96375 Compare September 1, 2017 16:16

mmalerba merged commit 426324b into angular:master Sep 11, 2017

josephperrott added a commit to josephperrott/components that referenced this pull request Sep 15, 2017

Allow snackbar position on the screen. (angular#4045)

c29c023

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(snackbar): allow snack bar to be positioned on the page #4045

feat(snackbar): allow snack bar to be positioned on the page #4045

josephperrott commented Apr 12, 2017

jelbourn left a comment

xtianus79 commented Apr 27, 2017

josephperrott commented May 10, 2017

jelbourn May 11, 2017

jelbourn May 11, 2017

jelbourn May 11, 2017

jelbourn May 11, 2017

jelbourn May 11, 2017

jelbourn May 11, 2017

soorireddy left a comment

xtianus79 commented May 17, 2017

mmalerba commented Jul 7, 2017

xtianus79 commented Jul 25, 2017

koumatsumoto commented Aug 18, 2017

xtianus79 commented Aug 18, 2017

josephperrott commented Aug 28, 2017

jelbourn commented Sep 1, 2017

josephperrott commented Sep 1, 2017

b4z81 commented Sep 11, 2017

xtianus79 commented Sep 26, 2017

jelbourn commented Sep 26, 2017

xtianus79 commented Sep 26, 2017

ORESoftware commented Feb 17, 2018

CDDelta commented Feb 18, 2018

ORESoftware commented Feb 18, 2018

angular-automatic-lock-bot bot commented Sep 8, 2019

feat(snackbar): allow snack bar to be positioned on the page #4045

feat(snackbar): allow snack bar to be positioned on the page #4045

Conversation

josephperrott commented Apr 12, 2017

jelbourn left a comment

Choose a reason for hiding this comment

xtianus79 commented Apr 27, 2017

josephperrott commented May 10, 2017

jelbourn May 11, 2017

Choose a reason for hiding this comment

jelbourn May 11, 2017

Choose a reason for hiding this comment

jelbourn May 11, 2017

Choose a reason for hiding this comment

jelbourn May 11, 2017

Choose a reason for hiding this comment

jelbourn May 11, 2017

Choose a reason for hiding this comment

jelbourn May 11, 2017

Choose a reason for hiding this comment

soorireddy left a comment

Choose a reason for hiding this comment

xtianus79 commented May 17, 2017

mmalerba commented Jul 7, 2017

xtianus79 commented Jul 25, 2017

koumatsumoto commented Aug 18, 2017

xtianus79 commented Aug 18, 2017

josephperrott commented Aug 28, 2017

jelbourn commented Sep 1, 2017

josephperrott commented Sep 1, 2017

b4z81 commented Sep 11, 2017

xtianus79 commented Sep 26, 2017

jelbourn commented Sep 26, 2017

xtianus79 commented Sep 26, 2017

ORESoftware commented Feb 17, 2018

CDDelta commented Feb 18, 2018

ORESoftware commented Feb 18, 2018

angular-automatic-lock-bot bot commented Sep 8, 2019