fix(dialog): provide default value for MD_DIALOG_DATA token #4120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a default value for the `MD_DIALOG_DATA` injection token, instead of throwing an error when it's not defined. Fixes angular#4086.
googlebot
added
the
cla: yes
jelbourn
reviewed
Apr 17, 2017
src/lib/dialog/dialog-config.ts
Outdated
| @@ -40,7 +40,7 @@ export class MdDialogConfig { | |||
| position?: DialogPosition; | |||
|
|
|||
| /** Data being injected into the child component. */ | |||
| data?: any; | |||
| data?: any = {}; | |||
jelbourn
added
pr: lgtm
action: merge
|
oddly I am gettig this error in a popup window... i.e. window.open... I know the values can't be passed there so I will try @optional() |
|
that was scary lol... @optional did the trick... I feel like this should just be obvious without dragging something in. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a default value for the
MD_DIALOG_DATAinjection token, instead of throwing an error when it's not defined.Fixes #4086.