feat(checkbox): adds invisible input element to leverage built-in functionality #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
cla: yes
| [attr.aria-label]="ariaLabel" | ||
| [attr.aria-labelledby]="labelId" | ||
| [attr.aria-checked]="getAriaChecked()" | ||
| [attr.aria-disabled]="disabled" |
There was a problem hiding this comment.
Are aria-checked and aria-disabled necessary for a native checkbox?
4 tasks
| <div class="md-checkbox-layout"> | ||
| <label class="md-checkbox-layout"> | ||
| <div class="md-checkbox-inner-container"> | ||
| <input #input class="md-checkbox-input" type="checkbox" |
There was a problem hiding this comment.
Why has the input a local variable? I can't see it used in any other sections
There was a problem hiding this comment.
Yeah, I don't think this is used any more.
There was a problem hiding this comment.
Ah, good call - it isn't used anymore.
Refactors checkbox to use native input element closes #250
|
LGTM |
andrewseguin
pushed a commit
to andrewseguin/components
that referenced
this pull request
Oct 15, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jelbourn @kara @hansl