chore: add CanDisable mixin to checkbox, radio-group, slide-toggle, and slider #4209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
reviewed
Apr 24, 2017
| @@ -369,8 +366,7 @@ export class MdRadioButton implements OnInit, AfterViewInit, OnDestroy { | |||
| } | |||
|
|
|||
| set disabled(value: boolean) { | |||
| // The presence of *any* disabled value makes the component disabled, *except* for false. | |||
| this._disabled = (value != null && value !== false) ? true : null; | |||
| this._disabled = coerceBooleanProperty(value); | |||
There was a problem hiding this comment.
Can we not use the mixin for the individual radio buttons too?
There was a problem hiding this comment.
The getter for indivual buttons is different (it checks the parent state as well as its own)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed a couple of unnecessary host class bindings while I was there.