Skip to content

Conversation

@ravinderpayal
Copy link

menu-caveate
As It's a feature the core team decided to add, and I was in need of this feature for functionality like drop-down menu having some setting controls where user may want to change multiple settings in one go. As currently after every click inside or outside of drop-down menu, it disappears. But adding some additional check based on the value of preventClose @input() supplied parent node can add this desired functionality. Actually I am creating a emoji picker, and have multiple categories of emoji, so user is required to change the category by clicking on tabs(Yeah I am using MD-tabs), menu disappears so this feature will help in accomplishing my specific requirement, and other people's similar requirements.

Changed the on click callback methodto `_emitClickCloseEvent` as this method as an additional logic for checking if `preventClose` is asked or not.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 2, 2017
@agostinalucia
Copy link

👏 thanks

@ravinderpayal ravinderpayal changed the title Fix(md-menu) : Added prevent close( when user clicks inside menu panel) feature Feat(md-menu) : Added prevent close( when user clicks inside menu panel) feature May 7, 2017
@ravinderpayal
Copy link
Author

ravinderpayal commented May 7, 2017

animation

After this feature.

@ravinderpayal
Copy link
Author

@alexweber @alexeagle @agostinalucia @mprobst Why not reviewed yet?

@willshowell
Copy link
Contributor

See @jelbourn's related comment here #4842 (comment)

@jelbourn
Copy link
Member

@ravinderpayal see #4842 for the discussion of why we do not want to add this feature.

Also note that tagging a bunch of random Angular team members is the absolute worst way to get a PR reviewed.

@jelbourn jelbourn closed this Jun 13, 2017
@ravinderpayal
Copy link
Author

@jelbourn sorry sir, our team was in urgent need of disableClose option, so I tagged the team members of Angular 2. But we are thankful to the angular 2 material team for adding md-expansion-panel.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants