fix(radio): refactor tests and fix ngModel #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
|
||
| groupDebugElement = fixture.debugElement.query(By.directive(MdRadioGroup)); | ||
| groupNativeElement = groupDebugElement.nativeElement; | ||
| groupInstance = groupDebugElement.injector.get(MdRadioGroup); |
There was a problem hiding this comment.
Is this the same as groupDebugElement.componentInstance?
There was a problem hiding this comment.
Nope; radio-group is a @Directive rather than a @Component, so it doesn't have a componentInstance.
|
@robertmesserle addressed comments |
| /** Updates the `selected` radio button from the internal _value state. */ | ||
| private _updateSelectedRadioFromValue(): void { | ||
| // Update selected if different from current value. | ||
| // If the value already matches the selected radio, no dothing. |
There was a problem hiding this comment.
Did you mean "do nothing"?
jelbourn
force-pushed
the
radio-test-refactor
branch
2 times, most recently
from
703129a to
98c0ac2
Compare
4 tasks
| * Initialize properties once content children are available. | ||
| * This allows us to propagate relevant attributes to associated buttons. | ||
| */ | ||
| ngAfterContentInit() { |
There was a problem hiding this comment.
Just curious, shouldn't this method be @internal?
jelbourn
force-pushed
the
radio-test-refactor
branch
from
98c0ac2 to
63a9fd9
Compare
jelbourn
force-pushed
the
radio-test-refactor
branch
from
63a9fd9 to
672e205
Compare
|
Verbal lgtm from @robertmesserle |
andrewseguin
pushed a commit
to andrewseguin/components
that referenced
this pull request
Oct 15, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @kara @robertmesserle
dirty(vs.pristineinitially)touchedcheckeddirectly on a radio button not updating the group'svalue.changeevent on initial setting of value at application load.@internal