build: separate demo-app in its own directory. #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| selector: 'md-card', | ||
| templateUrl: './components/card/card.html', | ||
| styleUrls: ['./components/card/card.css'], | ||
| templateUrl: 'ard.html', |
hansl
force-pushed
the
sourcedir
branch
4 times, most recently
from
4c612c6
to
2381c55
Compare
hansl
changed the title
hansl
force-pushed
the
sourcedir
branch
6 times, most recently
from
3be9e89
to
09b8276
Compare
hansl
added
pr: needs review
and removed
in progress
| var angularAppTree = new Angular2App(defaults, { | ||
| sourceDir: 'src/', | ||
| const appTree = buildAppTree(defaults); | ||
| const cssAutoprefixed = autoPrefixerTree(new Funnel(appTree, { |
There was a problem hiding this comment.
The changes in this file would use some high-level comments explaining what's going on.
|
LGTM |
|
@hansl looks like the inline-resources task isn't working. I think you just have to update the gulpfile. |
|
Don't tell me it doens't support relative path of resources :( |
hansl
force-pushed
the
sourcedir
branch
2 times, most recently
from
8142a83
to
c32c802
Compare
|
|
||
| /** | ||
| * Simple Promiseify function that takes a Node API and return a version that supports promises. | ||
| */ |
There was a problem hiding this comment.
Add comment for why you need this function in this script.
|
You're also got a lint error. |
This also improves upon the relative path problem. All template paths now should be relative. Also, we can now include double-quotes in CSS/HTML.
andrewseguin
pushed a commit
to andrewseguin/components
that referenced
this pull request
Oct 15, 2018
Fixes the body container collapsing on IE, causing the footer to show up right under the navigation.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.