Skip to content

demo(input): make character counters aria-live=polite #4600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2017
Merged

demo(input): make character counters aria-live=polite #4600

merged 1 commit into from
May 17, 2017

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented May 16, 2017 •
edited
Loading

fixes: #3585

@mmalerba mmalerba requested a review from kara May 16, 2017 17:49
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 16, 2017
kara
kara approved these changes May 16, 2017
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara removed their assignment May 16, 2017
@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 16, 2017
@jelbourn jelbourn merged commit ef6b9aa into angular:master May 17, 2017
@mmalerba mmalerba added the Accessibility This issue is related to accessibility (a11y) label May 18, 2017
@mmalerba mmalerba deleted the input-demo branch April 3, 2018 15:17
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A11y keyboard focus control in the Input example
4 participants
@mmalerba @kara @jelbourn @googlebot