fix(input): correct invalid colors #4771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make ripple & placeholder use warn color even with .mat-accent class - Make req'd asterisk warn color whenever input is invalid
googlebot
added
the
cla: yes
mmalerba
reviewed
May 24, 2017
src/lib/input/_input-theme.scss
Outdated
| .mat-placeholder-required { | ||
| color: $input-underline-color-warn; | ||
| .mat-input-placeholder { | ||
| &, &.mat-accent, &.mat-float .mat-placeholder-required { |
There was a problem hiding this comment.
can you put each selector on its own line (makes it obvious that there's multiple and not one complex one).
also I think we can't have rules that end with & in our theme files, so maybe:
.mat-input-placeholder {
color: $input-underline-color-warn;
&.mat-accent,
&.mat-float .mat-placeholder-required {
color: $input-underline-color-warn;
}
}
mmalerba
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4651
cc @mmalerba
It was all related to specificity issues, so I decreased the specificity of
.mat-input-ripple's background-color and increased it for.mat-input-placeholder's and.mat-placeholder-required's color.Also, I am unsure as to what the correct behavior for the required asterisk is. Previously, it was
accentwhile floating for all (primary, accent, warn) inputs. It was onlywarnwhen invalid and not focused. I chose to ensure it iswarnat all times when invalid, but can revert if that's contrary to the spec.