fix(select): unable to programmatically select falsy values #4868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
approved these changes
May 30, 2017
src/lib/select/select.spec.ts
Outdated
| @@ -449,6 +450,22 @@ describe('MdSelect', () => { | |||
| expect(fixture.componentInstance.select.selected).not.toBeDefined(); | |||
| }); | |||
|
|
|||
| it('should be able to programmatically select a falsy option', () => { | |||
There was a problem hiding this comment.
Nit: Why is this in its own section? Seems like it would better fit under forms integration since it has to do with setting the form control value.
src/lib/select/select.spec.ts
Outdated
| it('should be able to programmatically select a falsy option', () => { | ||
| fixture.destroy(); | ||
|
|
||
| let falsyFixture = TestBed.createComponent(FalsyValueSelect); |
src/lib/select/select.spec.ts
Outdated
| let falsyFixture = TestBed.createComponent(FalsyValueSelect); | ||
|
|
||
| falsyFixture.detectChanges(); | ||
| falsyFixture.debugElement.query(By.css('.mat-select-trigger')).nativeElement.click(); |
There was a problem hiding this comment.
Clicking on the trigger doesn't seem necessary if you're trying to test setting the value programmatically. Remove?
There was a problem hiding this comment.
It's there since we're also doing an extra check that the selected option has the proper class.
Fixes not being able to set falsy values progammatically in `md-select`. Fixes angular#4854.
crisbeto
force-pushed
the
4854/select-falsy-values
branch
from
99ecc03 to
d734c60
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes not being able to set falsy values progammatically in
md-select.Fixes #4854.