Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): panel in multiple mode not overlapping trigger #4952

Merged
merged 1 commit into from
Jun 7, 2017
Merged

fix(select): panel in multiple mode not overlapping trigger #4952

merged 1 commit into from
Jun 7, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 3, 2017

  • Fixes the select panel in multiple mode not overlapping the trigger completely.
  • Reformats the select.html to make it a little more manageable.

Fixes #4943.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 3, 2017
kara
kara approved these changes Jun 5, 2017
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit. Apply merge label when ready.

src/lib/select/select.ts Outdated
@@ -838,16 +838,18 @@ export class MdSelect implements AfterContentInit, OnDestroy, OnInit, ControlVal
const overlayRect = this.overlayDir.overlayRef.overlayElement.getBoundingClientRect();
const viewportRect = this._viewportRuler.getViewportRect();
const isRtl = this._isRtl();
const extraWidth = this.multiple ? SELECT_MULTIPLE_PANEL_PADDING_X + SELECT_PANEL_PADDING_X :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: extraWidth is a bit vague. How about paddingWidth ?

@kara kara assigned crisbeto and unassigned kara Jun 5, 2017
@crisbeto
fix(select): panel in multiple mode not overlapping trigger
fbbacbd 
* Fixes the select panel in multiple mode not overlapping the trigger completely.
* Reformats the select.html to make it a little more manageable.

Fixes angular#4943.
@crisbeto crisbeto force-pushed the 4943/select-multiple-panel-width branch from f48ace4 to fbbacbd Compare June 5, 2017 19:16
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 5, 2017
@andrewseguin andrewseguin merged commit 638a34a into angular:master Jun 7, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select overlay in multiple mode needs to extend further
4 participants
@crisbeto @kara @googlebot @andrewseguin