Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(typography): adjust breakpoints and add margins #5009

Merged
merged 1 commit into from
Jun 8, 2017
Merged

refactor(typography): adjust breakpoints and add margins #5009

merged 1 commit into from
Jun 8, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 7, 2017

  • Reworks the typography mappings to avoid excessively large headers. Previously the display-* breakpoints were mapped to h* elements, which was inaccurate. Now the display-* breakpoints aren't mapped to anything and the headers start from the headline breakpoint.
  • Replaces the subheader breakpoint with subheader-2 and subheader-1. subheader-2 correspond to the old subheader.
  • Adds margins to the headers and paragraphs.
  • Adds aliases that correspond exactly to the terminology from the spec.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 7, 2017
@crisbeto
refactor(typography): adjust breakpoints and add margins
5a34c29 
* Reworks the typography mappings to avoid excessively large headers. Previously the `display-*` breakpoints were mapped to `h*` elements, which was inaccurate. Now the `display-*` breakpoints aren't mapped to anything and the headers start from the `headline` breakpoint.
* Replaces the `subheader` breakpoint with `subheader-2` and `subheader-1`. `subheader-2` correspond to the old `subheader`.
* Adds margins to the headers and paragraphs.
* Adds aliases that correspond exactly to the terminology from the spec.
jelbourn
jelbourn approved these changes Jun 7, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jun 7, 2017
@andrewseguin andrewseguin merged commit 63db51f into angular:master Jun 8, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @andrewseguin