adds stylelint config settings #590
Conversation
googlebot
added
the
cla: yes
| @@ -1,5 +1,59 @@ | |||
| { | |||
| "rules": { | |||
| "color-hex-case": "lower", | |||
| "color-no-invalid-hex": true, | |||
There was a problem hiding this comment.
Man, now I won't be able use to chucknorris as a color any more.
| @@ -1,5 +1,59 @@ | |||
| { | |||
| "rules": { | |||
| "color-hex-case": "lower", | |||
There was a problem hiding this comment.
Easier to type and was more common in the existing code. Also personal preference.
| } | ||
|
|
||
| /** | ||
| * This mixin hides an element visually. | ||
| * That means it's still accessible for screen-readers but not visible in view. | ||
| * That means it"s still accessible for screen-readers but not visible in view. |
There was a problem hiding this comment.
Ah, that was the one I mentioned - forgot to re-push after fixing it =x
On Tue, May 31, 2016 at 5:57 PM, Ivey Padgett notifications@github.com
wrote:
In src/core/style/_mixins.scss
#590 (comment):}
/**
- This mixin hides an element visually.
- * That means it's still accessible for screen-readers but not visible in view.
- * That means it"s still accessible for screen-readers but not visible in view.
Missed a double quote 😄
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/angular/material2/pull/590/files/8fb026e39355a422b9e34fac2987bf85a0af9a68#r65288028,
or mute the thread
https://github.com/notifications/unsubscribe/AAi34wSiIQqHKa2z5pqu5R3bOuSki3rLks5qHNjogaJpZM4Iq1V-
.
|
I restarted browserstack. |
|
LGTM |
|
Grid list scss file needs single quotes on the import statement. |
|
@robertmesserle ping. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
R: @jelbourn @kara @hansl @iveysaur