demo: add select a11y demo #6384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tinayuangao
reviewed
Aug 10, 2017
|
|
||
| <div class="select-a11y-spacer"> | ||
| <md-select placeholder="Primary" color="primary"> | ||
| <md-option value="one">One</md-option> |
Contributor
There was a problem hiding this comment.
Also use real world examples in colored md-select?
crisbeto
force-pushed
the
6119/select-a11y
branch
from
4a2f422 to
869e380
Compare
jelbourn
reviewed
Aug 10, 2017
| <h2>Single selection</h2> | ||
| <p>Select your favorite color</p> | ||
|
|
||
| <md-select placeholder="Colors" [(ngModel)]="selectedColor"> |
Member
There was a problem hiding this comment.
Does each select need an aria-label?
Member
Author
There was a problem hiding this comment.
The select's aria-label defaults to the placeholder.
jelbourn
added
pr: lgtm
action: merge
Contributor
|
Please rebase |
andrewseguin
added
pr: needs rebase
and removed
action: merge
Adds an a11y demo page for `md-select`. Fixes angular#6119.
crisbeto
force-pushed
the
6119/select-a11y
branch
from
869e380 to
010ad64
Compare
crisbeto
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an a11y demo page for
md-select.Fixes #6119.