docs(input): remove extra parens and fix nits #6614
Conversation
googlebot
added
the
cla: yes
| @@ -14,7 +14,7 @@ elements inside `md-form-field` as well. This includes Angular directives such a | |||
|
|
|||
| The only limitations are that the `type` attribute can only be one of the values supported by | |||
| `mdInput` and the native element cannot specify a `placeholder` attribute if the `md-form-field` | |||
| also contains a `md-placeholder` element. | |||
| also contains an `md-placeholder` element. | |||
There was a problem hiding this comment.
Arguably haha. I'm basing it on the pronunciation of "md" sounding like "em dee". See APA blog referencing the subject.
| @@ -129,18 +129,18 @@ the error messages. | |||
| function myErrorStateMatcher(control: FormControl, form: FormGroupDirective | NgForm): boolean { | |||
| // Error when invalid control is dirty, touched, or submitted | |||
| const isSubmitted = form && form.submitted; | |||
| return !!(control.invalid && (control.dirty || control.touched || isSubmitted))); | |||
| return !!(control.invalid && (control.dirty || control.touched || isSubmitted)); | |||
There was a problem hiding this comment.
The coercion here seems to be unnecessary since all fields are boolean.
There was a problem hiding this comment.
Yeah it is unnecessary, but it's based on the default errorStateMatcher which originates from #3560 (comment).
Happy to change it if coercion is unnecessary, but it does add a little type safety. A little more discussion in #6585
There was a problem hiding this comment.
It has an effect because isSubmitted is potentially undefined (if form is undefined)
| @@ -129,18 +129,18 @@ the error messages. | |||
| function myErrorStateMatcher(control: FormControl, form: FormGroupDirective | NgForm): boolean { | |||
| // Error when invalid control is dirty, touched, or submitted | |||
| const isSubmitted = form && form.submitted; | |||
| return !!(control.invalid && (control.dirty || control.touched || isSubmitted))); | |||
| return !!(control.invalid && (control.dirty || control.touched || isSubmitted)); | |||
There was a problem hiding this comment.
It has an effect because isSubmitted is potentially undefined (if form is undefined)
jelbourn
added
docs
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.