Add ngModel support to button toggles #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -8,14 +8,16 @@ import { | |||
| fakeAsync, | |||
| tick, | |||
| } from '@angular/core/testing'; | |||
| import {NgControl} from '@angular/common'; | |||
There was a problem hiding this comment.
Can you add a TODO to update this to @angular/forms when we have rc.2?
|
Looks good aside from the two comments |
iveysaur
force-pushed
the
button-toggle-ng-model
branch
from
82f82da
to
20d5593
Compare
|
Address comments @devversion and @jelbourn |
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
alexeagle
pushed a commit
to alexeagle/material2
that referenced
this pull request
Nov 6, 2024
* build: enable codelyzer and most default Angular CLI TSLint rules - do some merging of tslint:recommended and our rules * fix(a11y): fix theme picker keyboard access enable Codelyzer a11y rules Relates to angular#671 * fix(component-overview): header does not show up in headings list Fixes angular#695 * fix(stack-blitz-button): no accessible label and description is not on correct element Fixes angular#693 * fix(example-viewer): no accessible label on View source button Fixes angular#693 * fix(component-sidenav): apply aria-current to selected nav items & improve contrast - use Roboto font instead of system-ui for `docs-nav-content-btn`s - use a different background color for selected route, in addition to different text color - increase opacity of `docs-nav-content-btn`s to meet contrast guidelines - switch to `mat-nav-list` to get the benefits of better contrast and hover/focus styles - plus slightly more padding for touch interfaces Fixes angular#694. Relates to angular#671. * fix: use header and main tags for more semantic HTML - improves screen reader support - footer tags were already properly used Relates to angular#671. * fix(component-nav): apply aria-label to navs - so that they can be differentiated by screen readers Relates to angular#671. * fix(component-nav): remove aria-label that duplicates messages - aria-expanded already covers whether the section can be toggled or not - the button's text content already covers the accessible name Relates to angular#671. * fix(header-link): remove title - the aria-label is sufficient Relates to angular#671. * feat(theme-picker): provide a visual preview of the theme colors via an SVG * fix(theme-picker,version-picker): add/improve aria-labels and tooltips Fixes angular#671 * fix: various a11y refinements - minify theme-demo-icon.svg - use & instead of / as it reads better on a screen reader - prefix classes with `docs-` - tell screen reader users when a theme has been selected Fixes angular#671
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jelbourn @kara