fix(button): allow for elevation to be overwritten #7305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
jelbourn,
josephperrott and
tinayuangao
as code owners
googlebot
added
the
cla: yes
jelbourn
reviewed
Sep 26, 2017
src/lib/button/_button-base.scss
Outdated
| @extend %mat-button-base; | ||
|
|
||
| @include mat-elevation(2); | ||
| &:not([class*='#{$_mat-elevation-prefix}']) { |
There was a problem hiding this comment.
Would it make sense to make a mixin for this? Something like...
@mixin mat-overridable-elevation($z) {
&:not([class*='#{$_mat-elevation-prefix}']) {
@include mat-elevation($z);
}
}There was a problem hiding this comment.
Good idea, that selector was pretty funky. Added.
Allows for the consumer to set the button elevation through the elevation classes, similarly to the menu, card and expansion components. Fixes angular#7264.
crisbeto
force-pushed
the
7264/button-elevation
branch
from
e377208 to
ffa1089
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for the consumer to set the button elevation through the elevation classes, similarly to the menu, card and expansion components.
Fixes #7264.