Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dialog): add styles and ability to close. #862

Merged
merged 1 commit into from
Jul 15, 2016
Merged

feat(dialog): add styles and ability to close. #862

merged 1 commit into from
Jul 15, 2016

Conversation

jelbourn
Copy link
Member

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 15, 2016
kara
kara reviewed Jul 15, 2016
View reviewed changes
src/components/dialog/dialog-container.scss
@include md-elevation(2);
overflow: hidden;

padding: 24px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be a Sass variable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@kara
Copy link
Contributor

kara commented Jul 15, 2016

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jul 15, 2016
@kara kara merged commit 758b851 into angular:master Jul 15, 2016
@jelbourn jelbourn deleted the dialog-style branch September 13, 2017 04:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jelbourn @kara @googlebot