Skip to content

feat(radio): add support for tabindex on radio-buttons #9467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jelbourn merged 1 commit into from
Jan 24, 2018
Merged

feat(radio): add support for tabindex on radio-buttons #9467

jelbourn merged 1 commit into from
Jan 24, 2018

Conversation

@devversion
Copy link
Member

@devversion devversion commented Jan 18, 2018

  • Adds support for tabIndex for the mat-radio-button.

Fixes #9427

@devversion
feat(radio): add support for tabindex on radio-buttons
8e13927 
* Adds support for `tabIndex` for the `mat-radio-button`.

Fixes angular#9427
@devversion devversion added pr: needs review target: patch This PR is targeted for the next patch release labels Jan 18, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 18, 2018
jelbourn
jelbourn approved these changes Jan 18, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jan 18, 2018
tinayuangao
tinayuangao approved these changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit f1c3e2c into angular:master Jan 24, 2018
@devversion devversion deleted the feat/radio-button-tabindex branch January 24, 2018 15:36
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

+1 more reviewer

@tinayuangao tinayuangao tinayuangao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Radio buttons are missing a tabindex input

4 participants

@devversion @jelbourn @tinayuangao @googlebot