Skip to content

Commit

Permalink
build: update jasmine to ~4.0
Browse files Browse the repository at this point in the history
Update jasmine to ~4.0 as otherwise sharded tests never fail.

```
yarn bazel test //ng-dev/release/publish/test:test
INFO: Analyzed target //ng-dev/release/publish/test:test (327 packages loaded, 9590 targets configured).
INFO: Found 1 test target...
Target //ng-dev/release/publish/test:test up-to-date:
  dist/bin/ng-dev/release/publish/test/test.sh
  dist/bin/ng-dev/release/publish/test/test_loader.js
  dist/bin/ng-dev/release/publish/test/test_require_patch.js
INFO: Elapsed time: 6.978s, Critical Path: 0.04s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
//ng-dev/release/publish/test:test                              (cached) PASSED in 5.6s
  Stats over 6 runs: max = 5.6s, min = 2.5s, avg = 4.5s, dev = 1.4s

Executed 0 out of 1 test: 1 test passes.
INFO: Build completed successfully, 1 total action
➜  dev-infra git:(breaking-changes-logs) ✗ yarn add jasmine@~4.0.0 --dev
➤ YN0000: Done with warnings in 2s 87ms

➜  dev-infra git:(breaking-changes-logs) ✗ yarn bazel test //ng-dev/release/publish/test:test
INFO: Analyzed target //ng-dev/release/publish/test:test (349 packages loaded, 9911 targets configured).
INFO: Found 1 test target...
FAIL: //ng-dev/release/publish/test:test (shard 4 of 6) (see /private/var/tmp/_bazel_alanagius/c1aa91bd594ada81591526950a169e56/execroot/dev-infra/bazel-out/darwin-fastbuild/testlogs/ng-dev/release/publish/test/test/shard_4_of_6/test.log)
```
  • Loading branch information
alan-agius4 committed Mar 10, 2022
1 parent 619eb9b commit f022914
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 8 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
"glob": "7.2.0",
"husky": "^7.0.1",
"inquirer": "^8.0.0",
"jasmine": "^3.7.0",
"jasmine": "~4.0.0",
"jsdoc": "^3.6.7",
"jsdom": "^19.0.0",
"karma": "^6.3.15",
Expand Down
21 changes: 14 additions & 7 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ __metadata:
glob: 7.2.0
husky: ^7.0.1
inquirer: ^8.0.0
jasmine: ^3.7.0
jasmine: ~4.0.0
jsdoc: ^3.6.7
jsdom: ^19.0.0
karma: ^6.3.15
Expand Down Expand Up @@ -7624,13 +7624,20 @@ __metadata:
languageName: node
linkType: hard

"jasmine-core@npm:^3.6.0, jasmine-core@npm:~3.99.0":
"jasmine-core@npm:^3.6.0":
version: 3.99.1
resolution: "jasmine-core@npm:3.99.1"
checksum: 4e4a89739d99e471b86c7ccc4c5c244a77cc6d1e17b2b0d87d81266b8415697354d8873f7e764790a10661744f73a753a6e9bcd9b3e48c66a0c9b8a092b071b7
languageName: node
linkType: hard

"jasmine-core@npm:^4.0.0":
version: 4.0.1
resolution: "jasmine-core@npm:4.0.1"
checksum: f097bf2c681acb55e03fb56a1569a9dfa8fcdf7c291aeb8786cb693c3a803ba2a59d6bac4c1facd239d778cc6f643d0a78920d9d278cba5d0cd46779b2546822
languageName: node
linkType: hard

"jasmine-core@npm:~2.8.0":
version: 2.8.0
resolution: "jasmine-core@npm:2.8.0"
Expand Down Expand Up @@ -7661,15 +7668,15 @@ __metadata:
languageName: node
linkType: hard

"jasmine@npm:^3.7.0":
version: 3.99.0
resolution: "jasmine@npm:3.99.0"
"jasmine@npm:~4.0.0":
version: 4.0.2
resolution: "jasmine@npm:4.0.2"
dependencies:
glob: ^7.1.6
jasmine-core: ~3.99.0
jasmine-core: ^4.0.0
bin:
jasmine: bin/jasmine.js
checksum: baa9a5d8555b844063cd6e11bb272d424a17fa3ebd31c62b211a80c9b8dbb4d9c26218b33212b4f8122e38204a443c2eefbcce89c1c72ee3f0044037ec651427
checksum: a65e1cf0deb6c54044004b4562461e29ebc7c6cf4b2edd2d7e06cd60a300c391761d2b5674aa7405d40307edb66316a8f9e496d538b5a86ea75447b63e40615f
languageName: node
linkType: hard

Expand Down

0 comments on commit f022914

Please sign in to comment.