-
Notifications
You must be signed in to change notification settings - Fork 56
[Proposal] Refactor ng-dev's pr directory to disentangle the utilities and common pieces #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
2 tasks done
Labels
Comments
josephperrott
added a commit
to josephperrott/dev-infra
that referenced
this issue
Sep 16, 2021
As part of angular#203, refactoring the pr directory into more reusable pieces.
josephperrott
added a commit
to josephperrott/dev-infra
that referenced
this issue
Sep 16, 2021
As part of angular#203, refactoring the pr directory into more reusable pieces.
josephperrott
added a commit
to josephperrott/dev-infra
that referenced
this issue
Sep 16, 2021
As part of angular#203, refactoring the pr directory into more reusable pieces.
josephperrott
added a commit
to josephperrott/dev-infra
that referenced
this issue
Sep 16, 2021
As part of angular#203, refactoring the pr directory into more reusable pieces.
josephperrott
added a commit
that referenced
this issue
Sep 16, 2021
josephperrott
added a commit
to josephperrott/dev-infra
that referenced
this issue
Sep 17, 2021
…common folder As part of angular#203, refactoring the pr directory into more reusable pieces
josephperrott
added a commit
to josephperrott/dev-infra
that referenced
this issue
Sep 17, 2021
…common folder As part of angular#203, refactoring the pr directory into more reusable pieces
josephperrott
added a commit
to josephperrott/dev-infra
that referenced
this issue
Sep 20, 2021
… attribute at pullRequest instead of merge Rather than using MergeConfig from merge in the ng-dev config object, we use PullRequestConfig from pullRequest as this config applies to all `pr` commands. Fixes angular#203 BREAKING CHANGE: `MergeConfig` has been renamed to `PullRequestConfig` and is now accessed via `pullRequest` on the provided ng-dev config.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently we have a structure like this.
We have had a few people ask for something akin to
ng-dev pr check <pr-number>
, which would return the pr title, number, if it needs approvals, what branches it would land in etc. I think we should transform thecheck-target-branches
into this command.I would propose that we then separate out a few pieces that can be reused both literally in other files/commands and conceptually.
config.ts
should move up one level intong-dev/pr
MergeConfig
should be renamed to something likePullRequestConfig
The text was updated successfully, but these errors were encountered: