Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atomic push #1038

Closed
wants to merge 3 commits into from
Closed

Atomic push #1038

wants to merge 3 commits into from

Conversation

josephperrott
Copy link
Member

See individual commits

@josephperrott
fix(ng-dev/pr): use atomic push when pushing to upstream merges
38d33d6 
Use the --atomic flag when pushing during merge so that we don't end up with only a partial push.
@josephperrott
fix(ng-dev/pr): add timeout to wait before commenting on pr merge
c424a5c 
Adding a 5 second wait before updating the pull request with a comment to attempt to address potential rate limitting.
@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Feb 23, 2023
devversion
devversion approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! --atomic is cool

ng-dev/pr/merge/strategies/autosquash-merge.ts Outdated Show resolved Hide resolved
@angular-robot
Copy link
Contributor

angular-robot bot commented Feb 23, 2023

This PR was merged into the repository by commit 1338115.

@angular-robot angular-robot bot closed this in d3026e7 Feb 23, 2023
angular-robot bot pushed a commit that referenced this pull request Feb 23, 2023
@josephperrott
fix(ng-dev/pr): add timeout to wait before commenting on pr merge (#1038
1338115 
)

Adding a 5 second wait before updating the pull request with a comment to attempt to address potential rate limitting.

PR Close #1038
@josephperrott josephperrott deleted the atomic-push branch February 23, 2023 19:11
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephperrott @devversion