Skip to content

fix(github-actions): properly delete obsolete branches #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(github-actions): properly delete obsolete branches #1104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85bffe9
fix(github-actions): properly delete obsolete branches
josephperrott Apr 14, 2023
6914653
fixup! fix(github-actions): properly delete obsolete branches
josephperrott Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion github-actions/create-pr-for-changes/lib/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ async function cleanUpObsoleteBranches(

// Delete the obsolete branches.
for (const branchName of obsoleteBranches) {
git.run(['push', getRepositoryGitUrl(forkRepo, git.githubToken), `:refs/heads/${branchName}`]);
git.run(['push', '-d', getRepositoryGitUrl(forkRepo, git.githubToken), branchName]);
}

core.info(`Deleted ${obsoleteBranches.length} obsolete branches.`);
Expand Down
2 changes: 1 addition & 1 deletion github-actions/create-pr-for-changes/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17509,7 +17509,7 @@ async function cleanUpObsoleteBranches(git, repo, forkRepo, branchPrefix) {
const obsoleteBranches = await Promise.all(obsoletePrs.map((pr) => getBranchNameForPr(git, repo, pr.number)));
core.info(`Found ${obsoleteBranches.length} obsolete branches that will be deleted: ` + (obsoleteBranches.length === 0 ? "-" : obsoleteBranches.join(", ")));
for (const branchName of obsoleteBranches) {
git.run(["push", getRepositoryGitUrl(forkRepo, git.githubToken), `:refs/heads/${branchName}`]);
git.run(["push", "-d", getRepositoryGitUrl(forkRepo, git.githubToken), branchName]);
}
core.info(`Deleted ${obsoleteBranches.length} obsolete branches.`);
}
Expand Down