Skip to content

Create ng-dev ci gather-test-results command #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Create ng-dev ci gather-test-results command #239

wants to merge 7 commits into from

Conversation

josephperrott
Copy link
Member

See individual commits.

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 22, 2021
@google-cla google-cla bot added the cla: yes label Sep 22, 2021
devversion
devversion approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nicely done. Just a few minor nits

@josephperrott
ci: update config scopes to include an ng-dev/ci and bazel/protos
6d5db18
@josephperrott
feat(bazel/protos): automatically generate typescript implementation …
65e2043 
…of bazel test_status proto

Load bazel test_status proto to the workspace and generate test_status protobuf javscript class
with typescript typings.
@josephperrott
feat(ng-dev/ci): create a common tool for gathering test results from…
c0a78f7 
… bazel

Create a common tool for gathering test results from bazel into a single directory for CircleCI to
ingest for test result tracking on CI.
@josephperrott
ci: use ng-dev ci gather-test-results instead of custom script for te…
2ea651c 
…st uploads on CI
@josephperrott
fixup! feat(ng-dev/ci): create a common tool for gathering test resul…
491a880 
…ts from bazel
@josephperrott
fixup! feat(bazel/protos): automatically generate typescript implemen…
aba9b6a 
…tation of bazel test_status proto
devversion
devversion approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@josephperrott josephperrott removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 23, 2021
@josephperrott
Copy link
Member Author

This PR was merged into the repository by commit f64f808.

josephperrott added a commit that referenced this pull request Sep 23, 2021
@josephperrott
feat(bazel/protos): automatically generate typescript implementation …
0a83a42 
…of bazel test_status proto (#239)

Load bazel test_status proto to the workspace and generate test_status protobuf javscript class
with typescript typings.

PR Close #239
josephperrott added a commit that referenced this pull request Sep 23, 2021
@josephperrott
feat(ng-dev/ci): create a common tool for gathering test results from…
cf92a66 
… bazel (#239)

Create a common tool for gathering test results from bazel into a single directory for CircleCI to
ingest for test result tracking on CI.

PR Close #239
josephperrott added a commit that referenced this pull request Sep 23, 2021
@josephperrott
ci: use ng-dev ci gather-test-results instead of custom script for te…
f64f808 
…st uploads on CI (#239)

PR Close #239
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 24, 2021
@josephperrott josephperrott deleted the ng-dev-ci branch August 10, 2022 19:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephperrott @devversion