Allow the credential service to be used for authentication for pr merge
#758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the improved typings allows for already defined Argv types to be passed through the addGithubTokenOption function
josephperrott
added
the
action: review
josephperrott
force-pushed
the
use-credential-service
branch
2 times, most recently
from
a15e2bb to
897781a
Compare
Allow for the usage of the ng-dev credential service for pr merging. This is currently hidden from users as we test it, though users are free to use it if they want to. As of now using the service for a merge requires the usage of the `--use-auth-service` flag.
josephperrott
force-pushed
the
use-credential-service
branch
from
897781a to
79bad90
Compare
josephperrott
changed the title
pr merge
devversion
approved these changes
Aug 8, 2022
josephperrott
added
action: merge
devversion
approved these changes
Aug 8, 2022
josephperrott
force-pushed
the
use-credential-service
branch
2 times, most recently
from
a6e3900 to
dc2bcde
Compare
josephperrott
force-pushed
the
use-credential-service
branch
from
dc2bcde to
f9bff9f
Compare
|
This PR was merged into the repository by commit 8842b87. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.