fix(ng-dev): always include the github token option on merge. #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
requested review from
clydin and
devversion
and removed request for
clydin
devversion
approved these changes
Aug 16, 2022
josephperrott
force-pushed
the
always-include-github
branch
from
53c42b7 to
b9807f8
Compare
During the transition from using the github token to using the ng-dev auth service, we need to always include the github token option. If we fail to include the option, when the `useNgDevAuthService` config value is not set to `true` no authentication mechanism for Github will be present.
josephperrott
force-pushed
the
always-include-github
branch
from
b9807f8 to
f4ef1d6
Compare
|
This PR was merged into the repository by commit 5d0da98. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the transition from using the github token to using the ng-dev auth service, we
need to always include the github token option. If we fail to include the option, when
the
useNgDevAuthServiceconfig value is not set totrueno authentication mechanismfor Github will be present.