-
Notifications
You must be signed in to change notification settings - Fork 56
fix(bazel/browsers): exclude a log file that chromium writes to on linux causing cache misses #795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
causing cache misses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As a potential workaround, in my protractor config file I tried passing the flags Passing |
This PR was merged into the repository by commit 7af5d34. |
exclude_patterns = [ | ||
# Exclude a log file that chromium writes to each run, causing remote cache | ||
# misses in downstream targets. | ||
"chrome-linux/chrome_debug.log", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a similar thing for e.g. Mac or Windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. I'll test both and report back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devversion It doesn't appear to cause cache misses on Windows.
On OSX, I can't determine due to other issues. Using bazel-provided chromium in unsandboxed execution fails early because it can't build runfiles due to all of the files with spaces in them. If I exclude all of those files, then the runfiles can be built but chromium fails, probably because it needs some of those files.
It's not clear to me why it works with sandboxed execution on OSX but fails when run outside of the sandbox. My understanding was that using --nobuild_runfile_links
fixed the runfiles with spaces issue but that doesn't seem to work for unsandboxed execution.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
@devversion I think this is the source of cache misses I'm seeing in angular/angular#47161. In unsandboxed execution (which is the case for targets run under RBE, right?) chromium will write to this log file each run in under the
external
dir causing remote cache misses on successive builds.