fix(ng-dev): order results of forks when searching for user owned forks #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that Github has made a change, or has introduced a bug in which unsorted results of forks for a repository with OWNER affiliation are returned as empty. Once ordering is provided the results show again as expected. While this should not be necessary, it is an innocuous change for us that is fine to remain indefinitely.
gkalpak
approved these changes
Aug 25, 2022
devversion
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
Super weird bug, can confirm the fix works.
@josephperrott can you capture the GitHub ticket outcome here?
|
This PR was merged into the repository by commit 806c568. |
|
@devversion will update once I have a response. |
|
It appears that whatever change was made that caused the issue was rolled back and the requests now return as expected. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that Github has made a change, or has introduced a bug in which unsorted results of forks for a repository with OWNER affiliation are returned as empty. Once ordering is provided the results show again as expected. While this should not be necessary, it is an innocuous change for us that is fine to remain indefinitely.