Skip to content

fix(github-actions): labels sync action not actually checking target repos #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

devversion
Copy link
Member

No description provided.

@devversion
Copy link
Member Author

devversion commented Nov 7, 2022

@josephperrott When we merge this, I think there may be labels that need to be renamed. The whole switch wasn't performed before. e.g. FW still has action: caretaker note, so might need to rename first?

Edit: I just fixed up caretaker note in the FW repo as the merge script expects that. Other labels still need to be cleaned up

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Nov 7, 2022
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angular-robot
Copy link
Contributor

angular-robot bot commented Nov 14, 2022

This PR was merged into the repository by commit f60c5f4.

@angular-robot angular-robot bot closed this in f60c5f4 Nov 14, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants