Schematics #1

hansl · 2017-05-23T22:53:16Z

No description provided.

Includes unit testing script and bunch of unit testing configuration.

This is not including a README, which will come later.

…ematics CLI

filipesilva · 2017-06-02T13:44:17Z

packages/schematics/README.md

+
+1. Create the Schematic Engine, and pass in a Collection and Schematic loader.
+1. Understand and respect the Schematics metadata and dependencies between collections. Schematics can refer to dependencies, and it's the responsibility of the tool to honor those dependencies. The reference CLI uses NPM packages for its collections.
+1. Create the Options object. Options can be anything, but the schematics can specify a JSON Schema that should be respected. The reference CLI, for example, parse the arguments as a JSON object and validate it with the Schema specified by the collection.


parse->parses

filipesilva · 2017-06-02T13:45:22Z

packages/schematics/README.md

+The tooling API is composed of the following pieces:
+
+## Engine
+The `SchematicEngine` is responsible for loading and constructing `Collection`s and `Schematics`'. When creating an engine, the tooling provides an `EngineHost` interface that understands how to create a `CollectionDescription` from a name, and how to create a `Schematic


Unclosed backtick at `Schematic

filipesilva · 2017-06-02T14:06:15Z

packages/schematics/src/exception/exception.ts

+ * found in the LICENSE file at https://angular.io/license
+ */
+
+export class BaseException extends Error {


This might not be a good idea in Ts 2.1+: https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#extending-built-ins-like-error-array-and-map-may-no-longer-work

It works in Node, I had that discussion with a lot of folks already.

I assume you're building down to ES2015 and requiring Node 7+ (I think), then? Because the only problems come if you're targeting ES5. If that's the case, you just need to add Object.setPrototypeof(this, BaseException.prototype) in the constructor, and you'll be fine in any version of Node.

Yes, we're targeting ES2015.

filipesilva · 2017-06-02T15:38:23Z

packages/schematics_cli/schematics/angular-app/files/karma.conf.js

+
+module.exports = function (config) {
+  config.set({
+    basePath: '),


'),->''

Done. Not sure how that ended up here.

filipesilva

Went through the big bits with Hans on a call, looks really good. Reference CLI has some really clean and descriptive usage patterns.

Great work on this Hans 👍

Better separation of concern between tooling and schematic library. Engine, Collection and Schematic now take a generic type that can add tooling-specific metadata to each parts, in a type-safe manner. Context exposed to schematics is a context of <any, any>, while the tool should use TypedContext for better support internally. The Engine Host now only deals with Descriptions of collection and schematics, does not deal with actual implementation. Renamed CliEngineHost to NodeModulesEngineHost, since its kind of reusable if you only implement a NodeModules schematic tool. Tempted to move this into the schematics library as its highly reusable. Added tooling/ in the schematics package, which contains implementations of some interfaces that should contain conventions.

…ne-host

Also, separation of concern for engine host has been improved, and a simple base implementation has been added. Tools should use this (or any subclasses provided) to implement their own EngineHost. This includes Google, which will use the FileSystem based one, and the Workbench which will use the Registry one.

Brocco · 2017-06-05T20:00:46Z

packages/schematics/package.json

+    "blueprints",
+    "code generation",
+    "schematics",
+    "Angular SDK"


sdk -> devkit
Angular SDK -> Angular DevKit

Brocco · 2017-06-05T20:01:04Z

packages/schematics/package.json

+  ],
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/angular/sdk.git"


repo name/url has changed

Brocco · 2017-06-05T20:01:26Z

packages/schematics/package.json

+  "bugs": {
+    "url": "https://github.com/angular/sdk/issues"
+  },
+  "homepage": "https://github.com/angular/sdk",


angular/devkit again

Brocco · 2017-06-06T21:02:24Z

packages/schematics/src/index.ts

+export * from './utility/path';
+
+
+export interface TreeConstructor {


I find it odd to have these tree definitions inside index.

Needs to be done where it's exported, but not in the interface definition (there's a circular dependency).

Brocco · 2017-06-06T21:29:50Z

packages/schematics/src/engine/schematic.ts

+import {BaseException} from '../exception/exception';
+
+import {Observable} from 'rxjs/Observable';
+import 'rxjs/add/observable/fromPromise';


fromPromise is not used

mgechev · 2017-06-07T17:38:50Z

packages/schematics/tooling/file-system-utility_spec.ts

+      c: 2
+    });
+  });
+});


Done. Added linting too.

mgechev · 2017-06-07T17:39:39Z

packages/schematics_cli/package.json

+  ],
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/angular/sdk.git"


devkit, not sdk

mgechev · 2017-06-07T17:39:51Z

packages/schematics_cli/package.json

+  "author": "Angular Authors",
+  "license": "MIT",
+  "bugs": {
+    "url": "https://github.com/angular/sdk/issues"


devkit, not sdk

mgechev · 2017-06-07T17:39:56Z

packages/schematics_cli/package.json

+    "url": "https://github.com/angular/sdk/issues"
+  },
+  "schematics": "./schematics/collection.json",
+  "homepage": "https://github.com/angular/sdk",


devkit, not sdk

Also added linting and fix those and a travis configuration.

wKoza · 2017-06-12T09:01:57Z

packages/schematics/src/sink/dryrun.ts

+ */
+import {FileSystemSink} from './filesystem';
+
+import {Observable} from 'rxjs';


prefer import {Observable} from 'rxjs/Observable';

Brocco · 2017-06-12T12:27:49Z

@wKoza agreed, want to submit a PR for that one and the import of Subject below as well?

googlebot added the cla: yes label May 23, 2017

hansl force-pushed the schematics branch 2 times, most recently from 4312e53 to cefa68a Compare May 26, 2017 00:36

hansl added 6 commits May 30, 2017 17:29

refactor: various housekeeping stuff

6cf93ab

build: add sdk-admin binary, bootstrap-local, ...

6cfd8ca

Includes unit testing script and bunch of unit testing configuration.

feat(@angular/schematics): implement the schematics library

9f618a1

This is not including a README, which will come later.

feat(@angular/schematics-cli): Implement the first version of the Sch…

4a53268

…ematics CLI

build: implement the first bazel configuration for DevKit

b48f616

refactor: add license headers to Schematics

a46c64e

hansl force-pushed the schematics branch 2 times, most recently from 974e60a to 18b3878 Compare June 2, 2017 02:23

filipesilva reviewed Jun 2, 2017

View reviewed changes

filipesilva approved these changes Jun 2, 2017

View reviewed changes

hansl force-pushed the schematics branch 5 times, most recently from 0c0a350 to 39f093d Compare June 2, 2017 22:44

hansl added 2 commits June 2, 2017 15:45

docs(@angular/schematics): add documentation for schematics

d422f9b

hansl force-pushed the schematics branch from 39f093d to 2fe2836 Compare June 2, 2017 22:46

hansl added 3 commits June 3, 2017 10:02

fix(@angular/schematics-cli): fix component schematics options

3f93cdc

fix(@angular/schematics): fix the null protocol for node-modules-engi…

62043f7

…ne-host

hansl mentioned this pull request Jun 6, 2017

[TRACKING] Custom Templates for Generators angular/angular-cli#6593

Closed

20 tasks

Brocco suggested changes Jun 7, 2017

View reviewed changes

mgechev suggested changes Jun 7, 2017

View reviewed changes

refactor: resolve comments from Mike and Ben

09b5cff

Also added linting and fix those and a travis configuration.

hansl force-pushed the schematics branch from f903728 to 09b5cff Compare June 7, 2017 18:20

mgechev approved these changes Jun 7, 2017

View reviewed changes

hansl merged commit 7f00fe3 into angular:master Jun 7, 2017

wKoza reviewed Jun 12, 2017

View reviewed changes

wKoza mentioned this pull request Jun 12, 2017

Don't import from 'rxjs' #2

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Schematics #1

Schematics #1

hansl commented May 23, 2017

filipesilva Jun 2, 2017

hansl Jun 2, 2017

filipesilva Jun 2, 2017

filipesilva Jun 2, 2017

hansl Jun 2, 2017

benlesh Jun 5, 2017

hansl Jun 7, 2017

filipesilva Jun 2, 2017

hansl Jun 2, 2017

filipesilva left a comment

Brocco Jun 5, 2017

hansl Jun 7, 2017

Brocco Jun 5, 2017

hansl Jun 7, 2017

Brocco Jun 5, 2017

hansl Jun 7, 2017

Brocco Jun 6, 2017

hansl Jun 7, 2017

Brocco Jun 6, 2017

hansl Jun 7, 2017

mgechev Jun 7, 2017

hansl Jun 7, 2017

mgechev Jun 7, 2017

hansl Jun 7, 2017

mgechev Jun 7, 2017

hansl Jun 7, 2017

mgechev Jun 7, 2017

hansl Jun 7, 2017

wKoza Jun 12, 2017

Brocco commented Jun 12, 2017

		export * from './utility/path';


		export interface TreeConstructor {

Schematics #1

Schematics #1

Conversation

hansl commented May 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

filipesilva left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Brocco commented Jun 12, 2017