This repository has been archived by the owner on Apr 9, 2022. It is now read-only.
feat(typescript): allow downlevelIteration in Angular 5 #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before TypeScript 2.3, when targeting ES5 (which is the case in Angular CLI),
for ... of
was limited toArray
. Meaning it's not possible to iterate easily on new iterables likeMap
.It's now possible since TypeScript 2.3, but requires the flag
downlevelIteration
. As Angular 5 requires TS >= 2.4, it's OK to enable this flag by default.@hansl @filipesilva @Brocco I don't know how to manage the option to be Angular >= 5 (or TypeScript >= 2.3) only in schematics. Is there a variable available for that, or is there another system to separate between Angular versions (as I suppose similar cases will happen) ?