This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Build Optimizer Lightweight Transformations #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
reviewed
Dec 26, 2017
| @@ -88,7 +88,7 @@ describe('build-optimizer', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('doesn\'t process files without decorators/ctorParameters/outside Angular', () => { | |||
| xit('doesn\'t process files without decorators/ctorParameters/outside Angular', () => { | |||
There was a problem hiding this comment.
Why is this test removed?
There was a problem hiding this comment.
The test should have been failing as prefix-classes will add the annotation but testPrefixClasses doesn't accept var Clazz = (function () { function Clazz() { } return Clazz; }());.
There was a problem hiding this comment.
I see, this test isn't true anymore at all since we do process all files in some capacity... Maybe it's better to wholly remove the test instead of just doing xit then. What do you think?
It's probably true that processing all files is what's leading to slow builds though.
There was a problem hiding this comment.
Removed the test as it is outdated now.
filipesilva
approved these changes
Jan 2, 2018
This was referenced Jan 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a transformation fast path when source maps are not enabled and transformers that require the type checker are not needed for a file (
scrub-file/fold-file). This also has the advantage of not running any of the built-in (and unneeded) transformers when used.There doesn't appear to be a publicly exposed mechanism to generate source maps with the TS printer. If this were possible, the source map limitation could be lifted.