Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

feat(@schematics/angular): strict option #462

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 5 additions & 1 deletion .appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,15 @@ install:
- ps: Install-Product node $env:nodejs_version
- npm install -g npm@~5.6.0
- npm install
# Appveyor (via chocolatey) cannot use older versions of Chrome:
# https://github.com/chocolatey/chocolatey-coreteampackages/tree/master/automatic/googlechrome
- npm run webdriver-update-appveyor

test_script:
- node --version
- npm --version
- npm run test
- npm test
- npm run test-large

build: off

Expand Down
20 changes: 20 additions & 0 deletions .circleci/bazel.rc
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# These options are enabled when running on CI
# We do this by copying this file to /etc/bazel.bazelrc at the start of the build.

# Echo all the configuration settings and their source
build --announce_rc

# Don't be spammy in the logs
build --noshow_progress

# Don't run manual tests
test --test_tag_filters=-manual

# Workaround https://github.com/bazelbuild/bazel/issues/3645
# Bazel doesn't calculate the memory ceiling correctly when running under Docker.
# Limit Bazel to consuming resources that fit in CircleCI "medium" class which is the default:
# https://circleci.com/docs/2.0/configuration-reference/#resource_class
build --local_resources=3072,2.0,1.0

# Retry in the event of flakes
test --flaky_test_attempts=2
98 changes: 55 additions & 43 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,39 +8,50 @@ _defaults: &defaults
_post_checkout: &post_checkout
post: git pull --ff-only origin "refs/pull/${CI_PULL_REQUEST//*pull\//}/merge"

_root_package_lock_key: &_root_package_lock_key
key: angular_devkit-{{ checksum "package-lock.json" }}

jobs:
lint:
install:
<<: *defaults
steps:
- checkout:
<<: *post_checkout
- restore_cache:
key: angular_devkit-{{ checksum "package-lock.json" }}

- checkout: *post_checkout
- restore_cache: *_root_package_lock_key
- run: npm install --no-save
- save_cache:
<<: *_root_package_lock_key
paths:
- "node_modules"

lint:
<<: *defaults
steps:
- checkout: *post_checkout
- restore_cache: *_root_package_lock_key
- run: npm run lint

validate:
<<: *defaults
steps:
- checkout
- restore_cache:
key: angular_devkit-{{ checksum "package-lock.json" }}

- run: npm install --no-save
- checkout: *post_checkout
- restore_cache: *_root_package_lock_key
- run: npm run validate -- --ci

test:
<<: *defaults
steps:
- checkout:
<<: *post_checkout
- restore_cache:
key: angular_devkit-{{ checksum "package-lock.json" }}

- run: npm install --no-save
- checkout: *post_checkout
- restore_cache: *_root_package_lock_key
- run: npm run test -- --code-coverage --full

test-large:
<<: *defaults
steps:
- checkout: *post_checkout
- restore_cache: *_root_package_lock_key
- run: npm run webdriver-update-circleci
- run: npm run test-large -- --code-coverage --full

integration:
<<: *defaults
steps:
Expand All @@ -53,7 +64,6 @@ jobs:
- restore_cache:
key: angular_devkit-integration-aio-{{ checksum "tests/@angular_devkit/build_optimizer/webpack/aio-app/package-lock.json" }}

- run: npm install --no-save
- run: xvfb-run -a npm run integration

- save_cache:
Expand All @@ -68,29 +78,23 @@ jobs:
build:
<<: *defaults
steps:
- checkout:
<<: *post_checkout
- restore_cache:
key: angular_devkit-{{ checksum "package-lock.json" }}

- run: bazel run @nodejs//:npm install
- run: bazel build //packages/...
- checkout: *post_checkout
- restore_cache: *_root_package_lock_key
- run: npm run admin -- build

- save_cache:
key: angular_devkit-{{ checksum "package-lock.json" }}
paths:
- "node_modules"
# build-bazel:
# <<: *defaults
# steps:
# - checkout: *post_checkout
# - run: sudo cp .circleci/bazel.rc /etc/bazel.bazelrc
# - run: bazel run @nodejs//:npm install
# - run: bazel build //packages/...

snapshot_publish:
<<: *defaults
steps:
- checkout:
<<: *post_checkout
- restore_cache:
key: angular_devkit-{{ checksum "package-lock.json" }}

- run: npm install --no-save
- checkout: *post_checkout
- restore_cache: *_root_package_lock_key
- run:
name: Decrypt Credentials
command: |
Expand All @@ -103,12 +107,8 @@ jobs:
publish:
<<: *defaults
steps:
- checkout:
<<: *post_checkout
- restore_cache:
key: angular_devkit-{{ checksum "package-lock.json" }}

- run: npm install --no-save
- checkout: *post_checkout
- restore_cache: *_root_package_lock_key
- run:
name: Decrypt Credentials
command: |
Expand All @@ -122,15 +122,27 @@ workflows:
version: 2
default_workflow:
jobs:
- lint
- validate
- install
- lint:
requires:
- install
- validate:
requires:
- install
- build:
requires:
- lint
- validate
# - build-bazel:
# requires:
# - lint
# - validate
- test:
requires:
- build
- test-large:
requires:
- build
- integration:
requires:
- build
Expand Down
90 changes: 64 additions & 26 deletions .monorepo.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,19 @@
},
"packages": {
"@_/benchmark": {
"version": "0.4.2",
"hash": "b1f9f2d8e1eca2a865d39263f0ca5a38"
"version": "0.5.6",
"hash": "37ed7e417435c92dbf301e7b26ea37ca"
},
"devkit": {
"version": "0.5.6",
"hash": "0f2c1274c1a33354e21586921fd4a29a"
},
"@angular/pwa": {
"name": "Angular PWA Schematics",
"section": "Schematics",
"version": "0.5.6",
"hash": "4cf615db59e59d114672e927f35c8973",
"snapshotRepo": "angular/angular-pwa-builds"
},
"@angular-devkit/architect": {
"name": "Architect",
Expand All @@ -53,14 +64,14 @@
"url": "https://github.com/angular/devkit/blob/master/packages/angular_devkit/architect/README.md"
}
],
"version": "0.0.3",
"hash": "57e25727cb63a879effb10fd30599987",
"version": "0.5.6",
"hash": "67cca04a43ff8a1bc5f3c12423569752",
"snapshotRepo": "angular/angular-devkit-architect-builds"
},
"@angular-devkit/architect-cli": {
"name": "Architect CLI",
"version": "0.0.3",
"hash": "c270aceb888087c61c0647771045fd47",
"version": "0.5.6",
"hash": "437cdb100a812bc10a08131cde7c3028",
"snapshotRepo": "angular/angular-devkit-architect-cli-builds"
},
"@angular-devkit/build-optimizer": {
Expand All @@ -71,21 +82,33 @@
"url": "https://github.com/angular/devkit/blob/master/packages/angular_devkit/build_optimizer/README.md"
}
],
"version": "0.4.2",
"hash": "55d5c82b05ef9b515e143356a75b895e",
"version": "0.5.6",
"hash": "31b9b564ff5e540ae704d8723445d1ad",
"snapshotRepo": "angular/angular-devkit-build-optimizer-builds"
},
"@angular-devkit/build-webpack": {
"name": "Build Webpack",
"@angular-devkit/build-ng-packagr": {
"name": "Build NgPackagr",
"links": [
{
"label": "README",
"url": "https://github.com/angular/devkit/blob/master/packages/angular_devkit/build_ng_packagr/README.md"
}
],
"version": "0.5.6",
"hash": "ef46e636df1a32ffd43ca795dbe20607",
"snapshotRepo": "angular/angular-devkit-build-ng-packagr-builds"
},
"@angular-devkit/build-angular": {
"name": "Build Angular",
"links": [
{
"label": "README",
"url": "https://github.com/angular/devkit/blob/master/packages/angular_devkit/build_webpack/README.md"
"url": "https://github.com/angular/devkit/blob/master/packages/angular_devkit/build_angular/README.md"
}
],
"version": "0.0.3",
"hash": "8165f0fc4dce547561e62e4e7605ea6e",
"snapshotRepo": "angular/angular-devkit-build-webpack-builds"
"version": "0.5.6",
"hash": "0de6ff5665a03357e496a40ebab64d84",
"snapshotRepo": "angular/angular-devkit-build-angular-builds"
},
"@angular-devkit/core": {
"name": "Core",
Expand All @@ -95,8 +118,8 @@
"url": "https://github.com/angular/devkit/blob/master/packages/angular_devkit/core/README.md"
}
],
"version": "0.4.2",
"hash": "3dc30c470d7cc9f3c7f226b4259eec28",
"version": "0.5.6",
"hash": "89c39fd109e35cfc39ca2d45f6da29ee",
"snapshotRepo": "angular/angular-devkit-core-builds"
},
"@angular-devkit/schematics": {
Expand All @@ -107,35 +130,50 @@
"url": "https://github.com/angular/devkit/blob/master/packages/angular_devkit/schematics/README.md"
}
],
"version": "0.4.2",
"hash": "9ac6f3bb734fa1e1751a005fb3c3124a",
"version": "0.5.6",
"hash": "5b1953260312043a7ad13929aaf62e3f",
"snapshotRepo": "angular/angular-devkit-schematics-builds"
},
"@angular-devkit/schematics-cli": {
"name": "Schematics CLI",
"version": "0.4.2",
"hash": "9df0b747019a04f8e01caddd642e7b52",
"version": "0.5.6",
"hash": "8e8ed56f8334efecbbcdaa889fb5e5fd",
"snapshotRepo": "angular/angular-devkit-schematics-cli-builds"
},
"@ngtools/webpack": {
"name": "Webpack Angular Plugin",
"version": "6.0.0-rc.4",
"section": "Misc",
"hash": "4346a38d1e70711671d3a5cac2959663",
"snapshotRepo": "angular/ngtools-webpack-builds"
},
"@schematics/angular": {
"name": "Angular Schematics",
"section": "Schematics",
"version": "0.4.2",
"hash": "f2f1253db8e7a01eb0e5a945dd08979c",
"version": "0.5.6",
"hash": "8a0904c4dacef4ff1e27f4641adfe187",
"snapshotRepo": "angular/schematics-angular-builds"
},
"@schematics/schematics": {
"name": "Schematics Schematics",
"version": "0.4.2",
"version": "0.5.6",
"section": "Schematics",
"hash": "c9723671e270d9d6eb7f4cdbfc37c77e"
"hash": "81ea3d90a8e85b15fd83c847af72c26c",
"snapshotRepo": "angular/schematics-schematics-builds"
},
"@schematics/package-update": {
"name": "Package JSON Update Schematics",
"version": "0.4.2",
"version": "0.5.6",
"section": "Schematics",
"hash": "1abc8090ac37083ca02f92ab794c6d7f",
"hash": "53654c259405585a652ba71c93cf7269",
"snapshotRepo": "angular/schematics-package-update-builds"
},
"@schematics/update": {
"name": "Package Update Schematics",
"version": "0.5.6",
"section": "Schematics",
"hash": "ac963f112efee0a83293d6b7d24bca89",
"snapshotRepo": "angular/schematics-update-builds"
}
}
}
27 changes: 0 additions & 27 deletions .travis.yml

This file was deleted.

Loading