Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

refactor(@angular-devkit/build-webpack): remove deploy URL option and CSS special cases #505

Closed
wants to merge 1 commit into from

Conversation

clydin
Copy link
Member

@clydin clydin commented Mar 13, 2018

Architect version of angular/angular-cli#9910

For reference, a comparison of the deploy URL and base HREF options can be found here: https://github.com/angular/angular-cli/blob/master/docs/design/deployurl-basehref.md

BREAKING CHANGE:

The deploy URL option has been removed. The base HREF option alone covers a majority of the use cases of the deploy URL option with the added benefit of affecting relative URL assets referenced in component HTML templates. For more advanced use cases, the Angular APP_BASE_HREF token can be used in conjuction to adjust the Angular routing root path.
Also, root-relative CSS resources will no longer be modified when a base HREF is present. For cases where a relative URL referenced resource should not be processed by the CLI, a caret ^ may be prefixed to the URL of the CSS resources to prevent the CLI from processing or otherwise modifying the URL and resource.

@clydin clydin changed the title refactor(@angular/cli): remove deploy URL option and CSS special cases refactor(@angular-devkit/build-webpack): remove deploy URL option and CSS special cases Mar 13, 2018
@luoguibin
Copy link

@clydin

a caret ^ may be prefixed to the URL of the CSS resources to prevent the CLI from processing
wow, it is the answer that i wanted

@alan-agius4
Copy link
Contributor

alan-agius4 commented Mar 24, 2018

This change is a bit of a bummer to be honest. Which in my case depend on quite a bit. I am using the deployUrl to set the CDN for my assets and bundles. Setting the baseHref will have an effect on all the relative urls within the page and not just the bundles which will cause all the site to break in case you use SSR as AFAIK crawls do use baseHref as if for example my links are /home or /about these will get redirected to the CDN rather than the actual url of the application.

For me personally removing the deployUrl seems to be big limitation.

@clydin clydin requested a review from filipesilva as a code owner May 18, 2018 01:43
@alexeagle
Copy link
Contributor

@clydin do we still need this? Closing since it's on the devkit repo.

@alexeagle alexeagle closed this Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants