This repository was archived by the owner on Apr 4, 2025. It is now read-only.
fix(@schematics/angular): use app as title #721
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the title is dynamic and use the prefix, then the e2e generated test should too. A simple way to avoid giving the prefix to the e2e schematic is to not use the prefix in the default title.
|
I prefer #720. I'm going to close this one in favor of the other one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the title is dynamic and use the prefix, then the e2e generated test should too.
A simple way to avoid giving the prefix to the e2e schematic is to not use the prefix in the default title.
This is an alternative solution to #720